Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edited message is incorrectly displayed within a thread #21447

Closed
frakic opened this issue Mar 17, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#8125
Closed

Edited message is incorrectly displayed within a thread #21447

frakic opened this issue Mar 17, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#8125
Assignees
@t3chguy
Labels
A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs

Comments

@frakic
Copy link

frakic commented Mar 17, 2022

Steps to reproduce

  1. Where are you starting? What can you see?
    -I'm in a room with some existing threads
  2. What do you click?
    -I edit the root message of a thread
  3. More steps…
    -I open that thread and view the root message

Outcome

What did you expect?

The edited version of the root message to be displayed within that thread

What happened instead?

The original version is displayed instead

Operating system

Windows 10 Home 21H1

Browser information

Firefox 98.0.1 (64-bit)

URL for webapp

https://develop.element.io

Application version

Element version: 071a541-react-176e49e31259-js-905a884f72e8 Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

No
@clokep
Copy link

clokep commented Mar 17, 2022

Does this always happen or only in encrypted rooms?

@germain-gg germain-gg added X-Needs-Info This issue is blocked awaiting information from the reporter S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Mar 18, 2022
@frakic
Copy link
Author

frakic commented Mar 18, 2022

Does this always happen or only in encrypted rooms?

It seems to only happen in encrypted rooms

@germain-gg germain-gg removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Mar 18, 2022
@t3chguy t3chguy assigned t3chguy and unassigned germain-gg Mar 22, 2022
@t3chguy t3chguy changed the title Edited root message is incorrectly displayed within a thread Edited message is incorrectly displayed within a thread Mar 23, 2022
@t3chguy
Copy link
Member

t3chguy commented Mar 23, 2022

This is not specific to root events due to https://github.com/matrix-org/matrix-spec-proposals/pull/2676/files#r827240084

@t3chguy t3chguy mentioned this issue Mar 23, 2022
Merged
@clokep clokep mentioned this issue Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with edited events not affecting threads matrix-org/matrix-react-sdk
4 participants
@clokep @germain-gg @t3chguy @frakic