Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading megolm keys from backup (be it online or offline) has become incredibly slow. #19778

Closed
Tracked by #757
ara4n opened this issue Nov 17, 2021 · 5 comments
Closed
Tracked by #757
Labels
A-E2EE A-E2EE-Key-Backup A-Performance O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Legacy-Crypto Issues affecting the legacy crypto stack

Comments

@ara4n
Copy link
Member

ara4n commented Nov 17, 2021

Steps to reproduce

  • Log in on new instance
  • Restore keys from online or offline backup. (124MB of keys for me)
  • Wait three hours.

Outcome

I have around 100,000 keys from memory, so I'd expect to be able to store them in indexeddb at (say) 50/s on a super speedy laptop (this is on a MacBook Pro Max), which would take ~30 minutes. Instead it took 3 hours.

Operating system

macOS 12.0.1 on M1

Application version

Nightly and App

How did you install the app?

No response

Homeserver

No response

Will you send logs?

Yes

@ara4n ara4n added the T-Defect label Nov 17, 2021
@ara4n
Copy link
Member Author

ara4n commented Nov 17, 2021

it's actually storing 30 keys/s into indexeddb :(

@SimonBrandner SimonBrandner added A-E2EE-Key-Backup A-Performance O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Nov 17, 2021
@Palid
Copy link
Contributor

Palid commented Nov 17, 2021

That sounds like some very weird case of partially fetching data and blocking the fetch before proper encryption/decryption of the previous part.

@Palid Palid added the A-E2EE label Nov 17, 2021
@neilalexander
Copy link

Although not quite as large, a 24MB key backup from the server took somewhere between 20 and 30 minutes to process for me yesterday on an M1 MacBook Pro also.

@richvdh
Copy link
Member

richvdh commented Mar 13, 2023

it's actually storing 30 keys/s into indexeddb :(

I wonder if this is related to #15476, where matthew has seen extreme slowness in encryption operations too.

@richvdh richvdh added the Z-Legacy-Crypto Issues affecting the legacy crypto stack label Nov 7, 2023
@richvdh
Copy link
Member

richvdh commented Apr 3, 2024

Closing as a duplicate of #15476

@richvdh richvdh closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE A-E2EE-Key-Backup A-Performance O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Legacy-Crypto Issues affecting the legacy crypto stack
Projects
None yet
Development

No branches or pull requests

5 participants