Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate getThread() on MatrixEvent #19612

Closed
Tracked by #3
germain-gg opened this issue Nov 4, 2021 · 1 comment
Closed
Tracked by #3

Deprecate getThread() on MatrixEvent #19612

germain-gg opened this issue Nov 4, 2021 · 1 comment
Assignees
@germain-gg
Labels
A-Threads T-Task Tasks for the team like planning

Comments

@germain-gg
Copy link
Contributor

There are times where the reference is held against an empty thread. Like in matrix-org/matrix-react-sdk#7080

After the integration with the servers, we will be able to revisit this approach and get rid of this altogether
@germain-gg germain-gg added T-Task Tasks for the team like planning A-Threads Z-ThreadsP0 labels Nov 4, 2021
@germain-gg germain-gg self-assigned this Nov 4, 2021
This was referenced Nov 4, 2021
Merged
Closed
@germain-gg germain-gg mentioned this issue Nov 12, 2021
Merged
@germain-gg
Copy link
Contributor Author

This is probably not going away as we need to have a way to know whether an event has a thread or not.
The zombie thread problem described in the original issue description has been mitigated differently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Threads T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@germain-gg