Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room settings save button can be incorrectly disabled even though there are changes #19283

Closed
dkasak opened this issue Oct 5, 2021 · 2 comments
Closed

Room settings save button can be incorrectly disabled even though there are changes #19283

dkasak opened this issue Oct 5, 2021 · 2 comments
Labels
A-Room-Settings good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect

Comments

@dkasak
Copy link
Member

dkasak commented Oct 5, 2021

Steps to reproduce

  1. Open Room Settings.
  2. Edit the Room Name field. The Save button gets enabled.
  3. Edit the Room Topic field. The Save button is still enabled.
  4. Revert the edit to the Room Topic field. The Save button now incorrectly gets disabled.

What happened?

What did you expect?

The Save button should remain enabled because the Room Name is still changed from the starting state.

What happened?

The Save button was disabled.

I'm using the Desktop version but this likely applies to Element Web too.

Operating system

Arch Linux

Application version

Element version: 1.8.5 Olm version: 3.2.3

How did you install the app?

pacman

Homeserver

No response

Have you submitted a rageshake?

No
@dkasak dkasak added T-Defect O-Occasional Affects or can be seen by some users regularly or most users rarely A-Room-Settings S-Minor Impairs non-critical functionality or suitable workarounds exist labels Oct 5, 2021
@germain-gg germain-gg added O-Occasional Affects or can be seen by some users regularly or most users rarely O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ and removed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Oct 7, 2021
@LoganArnett
Copy link

This issue relates to the matrix-org/matrix-react-sdk package itself

@LoganArnett LoganArnett mentioned this issue Oct 7, 2021
Merged
@t3chguy
Copy link
Member

t3chguy commented Oct 8, 2021

Fixed by matrix-org/matrix-react-sdk#6917

@t3chguy t3chguy closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-Settings good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dkasak @germain-gg @t3chguy @LoganArnett