Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsed room list appearance has regressed #17068

Closed
robintown opened this issue Apr 26, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6915
Closed

Collapsed room list appearance has regressed #17068

robintown opened this issue Apr 26, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6915
Assignees
@germain-gg
Labels
A-Room-List Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Milestone
App Team 1.9.3

Comments

@robintown
Copy link
Member

Description


This seems to be caused by c5a1bb2d2ce91b416e504ceb37a8e2a2a9f4c766.

Steps to reproduce

  • Collapse the room list

The "Start a chat" buttons should be circles, and there are spurious ellipses appearing when you hover over things.

Logs being sent: no
@t3chguy t3chguy mentioned this issue May 4, 2021
Closed
@t3chguy
Copy link
Member

t3chguy commented May 20, 2021

This is actually even worse when there are 0 rooms as the skeleton UI has regressed too
Screenshot from 2021-05-20 18-17-08

@SimonBrandner SimonBrandner added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label May 20, 2021
@SimonBrandner SimonBrandner mentioned this issue Jun 28, 2021
Closed
@t3chguy t3chguy mentioned this issue Jul 5, 2021
Closed
@robintown robintown added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed P1 labels Aug 22, 2021
@SimonBrandner SimonBrandner mentioned this issue Aug 23, 2021
Closed
@novocaine novocaine added S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Aug 26, 2021
@novocaine novocaine added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 26, 2021
@novocaine
Copy link
Contributor

Marking as O-Intermediate as this is closer to "some users frequently" than "most users regularly".

This was referenced Sep 19, 2021
Closed
Closed
@RokeJulianLockhart RokeJulianLockhart mentioned this issue Sep 22, 2021
Closed
@SimonBrandner SimonBrandner mentioned this issue Sep 24, 2021
Closed
@SimonBrandner SimonBrandner added the Help Wanted Extra attention is needed label Sep 24, 2021
@SimonBrandner SimonBrandner mentioned this issue Oct 1, 2021
Closed
@SimonBrandner
Copy link
Contributor

I am wondering if we could raise the priority of this as I've already closed quite a few duplicates of this

@germain-gg germain-gg self-assigned this Oct 5, 2021
@germain-gg germain-gg added this to the App Team 1.9.2 milestone Oct 5, 2021
@germain-gg germain-gg mentioned this issue Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Room-List Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
App Team 1.9.3
5 participants
@novocaine @germain-gg @t3chguy @SimonBrandner @robintown