Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users often accidentally ignore other users, and it's not very clear in the UI when you've done so #14633

Closed
Half-Shot opened this issue Jul 19, 2020 · 23 comments

Comments

@Half-Shot
Copy link
Member

There are two bugs here, one more clearly defined than the other. Often we find users appearing in #synapse-admins:matrix.org who are trying to debug why they can't contact another homeserver, only to find out that they have accidentally ignored a user. It's not clear how they are achieving this, although I can say that the button for ignoring people doesn't give any warnings or feedback so I can see how a misclick can cause this.

Secondly, it's very difficult to see if you've ignored someone in the UI at all. The ignore button changes text to "Unignore", but is styled in the same way as the other buttons. Ideally it would be highlighted very clearly when a user is is ignored.

@ara4n
Copy link
Member

ara4n commented Jul 20, 2020

pressing buttons at random on an unlocked phone in your pocket seems to be the most popular way to accidentally ignore people.

@niquewoodhouse
Copy link

Is this, in the mx_UserInfo, the only way people can ignore a user?

Screenshot 2020-08-03 at 20 09 03

When a user is ignored - do they disappear from timelines in the future? I just tested ignoring someone and I can still search for them in my room list and I can still see them in the mx_MemberList. So I think I can still contact them?

@Half-Shot when people are trying to debug this, are they searching for someone like that and not seeing the user in their lists? Would be super useful to have the flow documented I think (for me at least).

@t3chguy
Copy link
Member

t3chguy commented Aug 4, 2020

Ignoring does hide them from timeline. It does not hide rooms which happened to be named after them such as DMs. They can still see your messages. There is also an /ignore command.

@aaronraimist
Copy link
Collaborator

aaronraimist commented Aug 7, 2020

Been seeing lots of reports of this lately. This would be another thing that would be improved by https://github.com/matrix-org/matrix-doc/issues/1803 which suggests that ignores should not completely prevent new messages from being sent to you by the server, but instead should be filtered out client side and can be displayed (optionally) more like this:

rather than being completely missing.

@Half-Shot
Copy link
Member Author

Half-Shot commented Aug 7, 2020

This is what Discord does, and people are pretty mixed about it over there. Some people don't want to see messages from users at all if they have ignored them (although the feature could be a setting).

@niquewoodhouse They generally don't look in the user list, because usually the user believes it to be a networking problem rather than the user not actually being present in the room. The user list only tells you that someone is in your room, but it doesn't really tell you if everything is working.

Ideally people would notice that the member panel has a "Unignore" button, but it's not very visible among the other buttons.

@aaronraimist
Copy link
Collaborator

Right. I think that should be an option though, and probably the default when you ignore someone.

A short term relatively easy fix is to add a confirmation step when you click/tap Ignore. (It seems like a lot of these reports are Element Android users so it may be happening there)

@t3chguy
Copy link
Member

t3chguy commented Aug 7, 2020

That is how improved ignores in labs work fwiw

@Half-Shot
Copy link
Member Author

A short term relatively easy fix is to add a confirmation step when you click/tap Ignore. (It seems like a lot of these reports are Element Android users so it may be happening there)

I just tried it, turns out it does ask you to confirm it.

@Half-Shot
Copy link
Member Author

@t3chguy A possible solution to this bug might be to bring improved ignores out of labs :)

@aaronraimist
Copy link
Collaborator

aaronraimist commented Aug 7, 2020

@Half-Shot on Android?

On Web 1.7.3 it doesn't have any confirmation step for me.

@Half-Shot
Copy link
Member Author

Ah on Android yes

@MazeChaZer
Copy link

ignores should not completely prevent new messages from being sent to you by the server

But that isn't the case currently, the filtering is already happening in the client, isn't it? After I unblocked the person I accidentally ignored and cleared my client cache, past messages that were not displayed before came back.

@t3chguy
Copy link
Member

t3chguy commented Aug 8, 2020

the filtering is already happening in the client, isn't it?

Nope it gets applied to future syncs by the server.

@Biep
Copy link

Biep commented Aug 8, 2020

If the room member list used the same logic as the room list, there could be a category "Ignored" - a kind of analogue to "Low priority' or "History".

@ivanholmes
Copy link

This bit me today as well, I have no recollection of 'ignoring' the contact and wasted a couple of hours trying to find out what was wrong with the server.

Perhaps it would be useful to remind you that you've ignored someone when you try to message them, or show some kind of indication when you click on the room?

@aaronraimist
Copy link
Collaborator

@Half-Shot just wanted to follow up on the Android issue, I've created element-hq/element-android#1890 but maybe you can push that forward internally. It looks like the "Ignore" button in Element Android requires a confirmation but if you press and hold on a message, there is a "Block user" button which does the same thing however there is no confirmation required or even any change in the text of the button to indicate that you blocked them.

@resynth1943
Copy link
Contributor

Hello! Just chiming in, would like to amend my thoughts.

This is what Discord does, and people are pretty mixed about it over there. Some people don't want to see messages from users at all if they have ignored them

Yeah... if you do that, you should really consider adding a switch. There might be some form of bullying, and I doubt the victim wants to be constantly reminded when the bully is sharing his thoughts ("what did he say?"). That's one of my main gripes with Discord.

This bit me today as well, I have no recollection of 'ignoring' the contact and wasted a couple of hours trying to find out what was wrong with the server.

Same here. Apparently, I have ignored a user without knowing about it. No idea what's causing it, so I can't really debug it.

@erikjohnston
Copy link
Member

In Synapse land we see a steady trickle of people reporting bugs due to users accidentally ignoring people. Could I ask that implementing a confirmation dialog or something gets added to the road map pretty please? 👼

@robintown
Copy link
Member

From personal experience I know that it's far too easy to accidentally hit the "Reject and ignore" button on an invite instead of just "Reject" and never notice. I wouldn't be surprised if that's how most accidental ignores happen, which is why I would suggest hiding the option under a ... menu, like in the final design from #16869 (comment).

@MazeChaZer
Copy link

I believe for me it was the ignore button in mx_UserInfo, as @niquewoodhouse showed before. Something like this definitely needs a confirmation dialog, ignoring people accidentally is super stressful to debug. I am an experienced user and I really had trouble noticing that messages were missing and then finding the cause. Because I never used the ignore feature before I didn't think of it at all.

@ShadowJonathan
Copy link
Contributor

@aaronraimist:
...but instead should be filtered out client side and can be displayed (optionally) more like this:

rather than being completely missing.

@Half-Shot:
This is what Discord does, and people are pretty mixed about it over there. Some people don't want to see messages from users at all if they have ignored them (although the feature could be a setting).

I really like this approach, and to address half-shot's comment about this, how about ignoring people a two-step system;

  • You ignore a user, just like before, but their messages appear in the timeline with a "message hidden" status
  • Then, you can "hide" that user, which will remove their messages completely

This way, it's not a global setting, sometimes I wish not to see a person's messages instantly or without some mental preparation, and sometimes i wish not to see them at all.


Additionally, re that mockup: maybe change the shield icon to a grey one? Red catches the eye, and i think it wouldn't work well for something thats supposed to be "hidden"/out of the way.

@tadzik
Copy link

tadzik commented Jan 13, 2023

This continues being a massive pain for users who often report stuff as "not working" because they can't see messages from a bot they ignore.

Very often this could've been alleviated in a way that doesn't increase the amount of spam from an ignored user ­– if you're inviting an ignored user to a room, there's no harm in saying "you are ignoring that user, so you won't see them joining or replying to you".

@Johennes
Copy link
Contributor

Johennes commented Feb 2, 2023

The confirmation dialog was added with matrix-org/matrix-react-sdk#6116.

@t3chguy t3chguy closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests