Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsent messages banner disappears after a gappy sync #1145

Closed
matrixbot opened this issue Mar 14, 2016 · 2 comments
Closed

Unsent messages banner disappears after a gappy sync #1145

matrixbot opened this issue Mar 14, 2016 · 2 comments
Assignees
@richvdh
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Milestone
v1 - Private Preview

Comments

@matrixbot
Copy link

Created by @ richvdh:matrix.org.
@richvdh
Copy link
Member

richvdh commented Mar 14, 2016

If you have unsent messages in the timeline when a gappy /sync takes place, the unsent messages bar disappears despite the unsent messages still existing. (Actually it is delayed until something triggers a re-render in the RoomView, so the problem may not manifest immediately).

The problem is that RoomView only looks at the live timeline to decide if there are unsent messages.

The unsent messages also get stuck before more resent messages, in a manner similar to #1120.

@richvdh
Copy link
Member

richvdh commented Mar 14, 2016

If you click on 'resend unsent messages' after the gappy sync, but before it disappears, it does nothing, for similar reasons

@ara4n ara4n added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Mar 14, 2016
@ara4n ara4n added this to the v1 - Private Preview milestone Mar 14, 2016
@richvdh richvdh mentioned this issue Mar 17, 2016
Merged
@richvdh richvdh closed this as completed Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richvdh richvdh

Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
v1 - Private Preview
Development

No branches or pull requests
3 participants
@ara4n @richvdh @matrixbot