Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InApp Camera #1389

Open
bmarty opened this issue May 20, 2020 · 5 comments · May be fixed by #6763
Open

InApp Camera #1389

bmarty opened this issue May 20, 2020 · 5 comments · May be fixed by #6763

Comments

@bmarty
Copy link
Member

bmarty commented May 20, 2020

Use inApp Camera to take photo to send them to a room.
Using the new CameraX API: https://developer.android.com/training/camerax

For the moment, this feature will be enabled at compilation time. If enabled, the external camera app will never be opened from RiotX.

@kojid0
Copy link
Contributor

kojid0 commented May 25, 2020

I'd very appreciate if we can still access the external camera if wanted. In-app cameras usually don't have the same quality as the actual external device-camera app. Don't know how the plans for riotx in-app camera look like but maybe long-click on the preview could still open external camera app?

@TR-SLimey
Copy link
Contributor

I doubt anyone would need to switch frequently between the two so a simple setting might be enough. For example, Settings > Preferences > Use system camera.

@kojid0
Copy link
Contributor

kojid0 commented Jun 21, 2020

I doubt anyone would need to switch frequently between the two so a simple setting might be enough. For example, Settings > Preferences > Use system camera.

Don't know if we are talking about the same InApp Camera Feature but I thought about something like this (screenshot from Telegram):
riotx

By tapping on the camera preview, the InApp Camera opens. Long tapping will activate native camera (better quality).

Please refrain from making yet another setting - IMO there are already have too many which make riot look complicated for "normal" users.

@TR-SLimey
Copy link
Contributor

I see what you mean. Yeah, that makes sense.

@omentic
Copy link

omentic commented May 21, 2021

What would the benefit of using an in-app camera be? I'm personally always frustrated by this behavior in Discord, because it doesn't allow me to use more advanced camera features.

@p1gp1g p1gp1g linked a pull request Aug 7, 2022 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants