This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Assign generated init funcs unique names #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all generated init funcs would receive the same name, which made them impossible to differentiate in traces and profiling output. We now assign each function a unique name based on its associated class. Further, we can now add "fake" linecache entries for our generated functions so that debuggers (like PDB) and the traceback module can better understand the generated code.
jparise
changed the title
jparise
changed the title
|
👍 Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all generated init funcs would receive the same name, which made
them impossible to differentiate in traces and profiling output. We now assign
each function a unique name based on its associated class.
Further, we can now add "fake" linecache entries for our generated functions
so that debuggers (like PDB) and the traceback module can better understand
the generated code.