New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patience & Tolerance values hard-coded to 3 and 1e-3 respectively #24

Open

rajatg-sidefx opened this issue Oct 28, 2022 · 1 comment · May be fixed by #30

rajatg-sidefx commented Oct 28, 2022 •

edited

Loading

In class MyDemBones of mainCmd.cpp, the member variables tolerance and patience are initialized to (1e-3) and (3).

However, these values are never updated to those passed in via the command line.

It looks like the following lines must be added to the main function to ensure that the user-provided arguments are being respected:

model.tolerance = tolerance.getValue();
model.patience = patience.getValue();

The text was updated successfully, but these errors were encountered:

Contributor

zigguratvertigo commented Jan 5, 2024

Thanks for noticing. Got PR?

rajatg-sidefx linked a pull request

that will close this issue

Update model with user-provided tolerance and patience values #30

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment