Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

feat(saveSourceMap): honor source folder hierarchy #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(saveSourceMap): honor source folder hierarchy #186

wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Feb 21, 2017

This PR is following changes to #185 and improves behavior of saving sourcemap, by honoring appRoot and create relative path under sourcemapPath when generates sourcemap.

This behavior supports 2 usecases,

  • if there are same file name under different paths (src/main/main.ts, src/renderer/main.ts) flattened sourcemap emission will overwrite one eventually
  • sourcemap lookup based on sourceroot / maproot is based on relative path hierarchy of original source, so if someone try to utilize it they may need to reconstruct structures from flattened one.

Now with this PR by default it honors appRoot and construct same hierarchies, and if someone need to flatten sourcemap can do after compilation is done. (manually).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant