-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cell actions being added to more places in Security app #3296
Conversation
Documentation previews: |
|
||
* *Filter In*: Add a filter that includes the selected value. | ||
* *Filter Out*: Add a filter that excludes the selected value. | ||
* *Add to timeline*: Launch Timeline and populate a query with the selected value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 2 kinds of actions which add filters to the Timeline:
-
Investigate in Timeline: Clears the Timeline, adds the cell filter(s) to timeline and automatically opens the timeline. It is used in the Detecion & Response dashboard, and in the Entity Analytics dashboard. (there are also "row actions" in the first column of the alerts/events tables that do the same thing, but those are not CellActions)
-
Add to Timeline: Adds the cell filter(s) to Timeline without clearing the previous values, and it does not open the timeline. It is used everywhere else, alerts/events table cells, visualizations legends, details flyouts...
@stephmilovic did I miss anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions for your consideration, thanks! Good call on creating a dedicated spot to describe this feature
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have the one question - lgtm otherwise!
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small suggestions, then this is good to go. Thanks!
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
@elasticmachine run elasticsearch-ci/docs |
* First draft * Small edits * Moar actions, edits * Apply suggestions from Ben's review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Apply suggestions from Ben's review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Correct description for Add to timeline * Update docs/getting-started/security-ui.asciidoc * Update docs/getting-started/security-ui.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 90ab9e4)
* First draft * Small edits * Moar actions, edits * Apply suggestions from Ben's review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Apply suggestions from Ben's review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Correct description for Add to timeline * Update docs/getting-started/security-ui.asciidoc * Update docs/getting-started/security-ui.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 90ab9e4) Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Resolves #2953.
Previews: