Cell actions being added to more places in Security app #3296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation previews: |
joepeeples
requested review from
machadoum,
semd,
jmikell821,
nastasha-solomon and
benironside
semd
reviewed
May 18, 2023
|
|
||
| * *Filter In*: Add a filter that includes the selected value. | ||
| * *Filter Out*: Add a filter that excludes the selected value. | ||
| * *Add to timeline*: Launch Timeline and populate a query with the selected value. |
There was a problem hiding this comment.
We have 2 kinds of actions which add filters to the Timeline:
-
Investigate in Timeline: Clears the Timeline, adds the cell filter(s) to timeline and automatically opens the timeline. It is used in the Detecion & Response dashboard, and in the Entity Analytics dashboard. (there are also "row actions" in the first column of the alerts/events tables that do the same thing, but those are not CellActions)
-
Add to Timeline: Adds the cell filter(s) to Timeline without clearing the previous values, and it does not open the timeline. It is used everywhere else, alerts/events table cells, visualizations legends, details flyouts...
@stephmilovic did I miss anything?
benironside
reviewed
May 19, 2023
joepeeples
commented
May 22, 2023
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
4 tasks
nastasha-solomon
approved these changes
May 22, 2023
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
jmikell821
reviewed
May 22, 2023
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
|
@elasticmachine run elasticsearch-ci/docs |
mergify bot
pushed a commit
that referenced
this pull request
May 22, 2023
* First draft * Small edits * Moar actions, edits * Apply suggestions from Ben's review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Apply suggestions from Ben's review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Correct description for Add to timeline * Update docs/getting-started/security-ui.asciidoc * Update docs/getting-started/security-ui.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 90ab9e4)
joepeeples
added a commit
that referenced
this pull request
May 22, 2023
* First draft * Small edits * Moar actions, edits * Apply suggestions from Ben's review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Apply suggestions from Ben's review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Correct description for Add to timeline * Update docs/getting-started/security-ui.asciidoc * Update docs/getting-started/security-ui.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 90ab9e4) Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2953.
Previews: