Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested grouping and beta label removed from grouping #3283

Merged
merged 9 commits into from
May 23, 2023

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented May 16, 2023

@github-actions
Copy link

Documentation previews:

@joepeeples joepeeples marked this pull request as ready for review May 18, 2023 16:10
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a suggestion for your consideration

docs/detections/alerts-ui-manage.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


[role="screenshot"]
image::images/group-alerts.png[Alerts table with Group alerts by drop-down]

Each group displays information such as the alerts' severity and how many users, hosts, and alerts are in the group. The type of information displayed varies depending on the selected field.
Each group displays information such as the alerts' severity and how many users, hosts, and alerts are in the group. The information displayed varies depending on the selected fields.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe describe how the selection order will determine the nesting order, and that the order is displayed in the "Group alerts by" label?

Copy link
Contributor Author

@joepeeples joepeeples May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephmilovic We do mention the nesting order in the previous paragraph, above the screenshot, but I've added something about how the order is displayed in the label.

@joepeeples joepeeples merged commit cf861e4 into main May 23, 2023
mergify bot pushed a commit that referenced this pull request May 23, 2023
* Remove beta tag

* First draft

* Fix typo, edit

* Small fix

* Apply suggestions from code review

* Apply suggestions from Steph's review

(cherry picked from commit cf861e4)
@joepeeples joepeeples deleted the 3280-nested-grouping-alerts branch May 23, 2023 20:17
joepeeples added a commit that referenced this pull request May 23, 2023
* Remove beta tag

* First draft

* Fix typo, edit

* Small fix

* Apply suggestions from code review

* Apply suggestions from Steph's review

(cherry picked from commit cf861e4)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@joepeeples joepeeples mentioned this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested grouping and beta label removed from grouping
5 participants