Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write troubleshooting docs for max alerts warning #3262

Merged
merged 12 commits into from
May 22, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented May 13, 2023

@github-actions
Copy link

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review May 14, 2023 23:10
docs/detections/rules-ui-monitor.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-monitor.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, LGTM!

docs/detections/rules-ui-monitor.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-monitor.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a couple minor suggestions

docs/detections/rules-ui-monitor.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-monitor.asciidoc Outdated Show resolved Hide resolved
nastasha-solomon and others added 3 commits May 20, 2023 15:21
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'd like to check w/ UX Writing how we should be styling messages, warnings, etc. that appear in the UI. For some reason I thought they should be bolded, but it's something we'll check to ensure it's consistent henceforth. Good to merge 👍

@nastasha-solomon nastasha-solomon merged commit 67e4041 into main May 22, 2023
mergify bot pushed a commit that referenced this pull request May 22, 2023
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 67e4041)
@nastasha-solomon nastasha-solomon deleted the issue-3187-max-warn-troubleshoot branch May 22, 2023 16:51
nastasha-solomon added a commit that referenced this pull request May 22, 2023
…) (#3327)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write troubleshooting docs for max alerts warning
5 participants