[8.8] Vulnerability management integration docs #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation previews: |
nick-alayil
approved these changes
May 8, 2023
docs/cloud-native-security/vuln-management-get-started.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Very clear and well-written instructions and explanations, @benironside! I left some suggestions and questions for your consideration but overall, everything looks great!
docs/cloud-native-security/vuln-management-get-started.asciidoc
Outdated
Show resolved
Hide resolved
jmikell821
reviewed
May 16, 2023
There was a problem hiding this comment.
Hey @benironside, left some suggestions for your review. I think you could add some more screenshots in a few places. If you have one of AWS, that'd be great, but if not, understood. I'd like us to take another pass once feedback is merged. Thanks!
docs/cloud-native-security/vuln-management-get-started.asciidoc
Outdated
Show resolved
Hide resolved
docs/cloud-native-security/vuln-management-get-started.asciidoc
Outdated
Show resolved
Hide resolved
docs/cloud-native-security/vuln-management-get-started.asciidoc
Outdated
Show resolved
Hide resolved
docs/cloud-native-security/vuln-management-get-started.asciidoc
Outdated
Show resolved
Hide resolved
docs/cloud-native-security/vuln-management-get-started.asciidoc
Outdated
Show resolved
Hide resolved
docs/cloud-native-security/vuln-management-get-started.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
benironside
commented
May 17, 2023
joepeeples
reviewed
May 19, 2023
docs/cloud-native-security/vuln-management-get-started.asciidoc
Outdated
Show resolved
Hide resolved
docs/cloud-native-security/vuln-management-get-started.asciidoc
Outdated
Show resolved
Hide resolved
| . Switch back to the tab where you have {kib} open. | ||
| . Click *Launch CloudFormation*. The CloudFormation page appears. | ||
| + | ||
| image::images/cnvm-cloudformation.png[The cloud formation template] |
There was a problem hiding this comment.
This screenshot feels unnecessary — not because it's not our UI, but because the user is doing almost nothing on this screen other than just click through (with one optional config change). Even if this were a Kibana UI, I'd rethink whether the user needs a huge screenshot (and whether we want to maintain it) just to click a single, pretty conspicuous button.
There was a problem hiding this comment.
I tend to agree but I'll defer to @jmikell821 on this one, since I added the AWS image at her suggestion.
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
|
@benironside with all the changes made so far. It looks awesome documentation and a great start for a brand new feature. Thank you @benironside and all the reviewers (@jmikell821 , @nastasha-solomon , @joepeeples ) 🙏 !! |
|
A few minor comments/questions: In set up CNVM for AWS section, in the highlighted important note, we're asking the reader to go How CNVM works but the text shown is Vulnerability Management overview as shown below. Shouldn't the text be
In KSPM and CSPM , FAQ page header is Also in CNVM FAQ, the answers are not starting in a newline like CSPM FAQ. |
Closed
|
This pull request is now in conflicts. Could you fix it @benironside? 🙏 |
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2023
* First draft * fixes ToC issue * updates from conversation with Nick and more edits * Incorporates Nick's feedback * minor edit * Incorporates Nick's feedback * Minor change * incorporates Nastasha's feedback! * Update docs/cloud-native-security/vuln-management-overview.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-overview.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-overview.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-overview.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * test adding image * minor edt * Adds FAQ and images * Update docs/cloud-native-security/vuln-management-faq.asciidoc * Update docs/cloud-native-security/vuln-management-overview.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Incorporates Joe's review * Incorporates Nick's feedback :) --------- Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit c91c92d)
benironside
added a commit
that referenced
this pull request
May 23, 2023
* First draft * fixes ToC issue * updates from conversation with Nick and more edits * Incorporates Nick's feedback * minor edit * Incorporates Nick's feedback * Minor change * incorporates Nastasha's feedback! * Update docs/cloud-native-security/vuln-management-overview.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-overview.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-overview.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/cloud-native-security/vuln-management-overview.asciidoc Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * test adding image * minor edt * Adds FAQ and images * Update docs/cloud-native-security/vuln-management-faq.asciidoc * Update docs/cloud-native-security/vuln-management-overview.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/vuln-management-get-started.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Incorporates Joe's review * Incorporates Nick's feedback :) --------- Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit c91c92d) Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3158
Adds pages for the Cloud Native Vulnerability Management (CNVM) feature / Elastic Vulnerability Management for Cloud (EVMC) integration.
3 new pages: Preview