Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map as another reference type to check to show warnings #414

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Sep 13, 2022

What does this PR do?

This PR updates validation rule that shows warnings in case of reference types to include "map" as another element to be taken into account according to #316 (comment).

Follow up of this PR #389

Checklist

- [ ] I have added test packages to test/packages that prove my change is effective.

Related issues

@mrodm mrodm self-assigned this Sep 13, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-13T10:05:57.094+0000

  • Duration: 7 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 622
Skipped 0
Total 622

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 70.833% (17/24) 👍
Classes 78.788% (26/33) 👍
Methods 58.824% (60/102) 👍
Lines 44.592% (536/1202) 👎 -0.037
Conditionals 100.0% (0/0) 💚

@mrodm mrodm added the Team:Ecosystem Label for the Packages Ecosystem team label Sep 13, 2022
@mrodm mrodm marked this pull request as ready for review September 13, 2022 13:47
@mrodm mrodm requested a review from a team as a code owner September 13, 2022 13:47
@mrodm mrodm merged commit 1cbee8f into elastic:main Sep 13, 2022
@mrodm mrodm deleted the add_more_reference_types_warning branch September 13, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants