-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Design Pass: Role mappings #96882
[Enterprise Search] Design Pass: Role mappings #96882
Conversation
Accidentally deleted it refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App Search is good by me. Thanks @scottybollinger
For App Search's empty state on Users & Roles, can we remove the 1px border panel that's around the light gray/subdued panel? All else looks great!! |
That border seems consistent with every App Search view in Kibana and the separation in design was already in place. @daveyholler is that pattern something you want to keep? |
Requested to remove for empty state
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also not sure if we want the disparity between AS and WS empty states.
But code changes LGTM.
* Update shared button color and panel shading * Vertically align table cells to top * [App Search] Update panels to have backgrounds not borders * [Workplace Search] Update panels to have backgrounds not borders * re-align last cell to right Accidentally deleted it refactoring * Conditionally have border for App Search Requested to remove for empty state
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* Update shared button color and panel shading * Vertically align table cells to top * [App Search] Update panels to have backgrounds not borders * [Workplace Search] Update panels to have backgrounds not borders * re-align last cell to right Accidentally deleted it refactoring * Conditionally have border for App Search Requested to remove for empty state Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
Summary
This PR completes the checklist items for Role mappings here.
Changes requested:
Went ahead and applied the same changes to App Search while I was here. I only did the screenshot for App Search for the table cell alignment since this is a shared component.
Best to review each commit with whitespace changes hidden.
App Search
Workplace Search
Checklist