Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Importing saved objects from 6.x to 7.x #96869

Merged
merged 6 commits into from
Apr 13, 2021

Conversation

bhavyarm
Copy link
Contributor

This is part 2 for making sure users can import saved objects between versions. Its importing saved objects from 6.8.x to 7.x.

This PR handled it for 7.x to 8.0.0 #91908

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm bhavyarm requested a review from LeeDr April 12, 2021 21:49
@bhavyarm bhavyarm marked this pull request as ready for review April 12, 2021 22:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@bhavyarm bhavyarm added the release_note:skip Skip the PR/issue when compiling release notes label Apr 12, 2021
beforeEach(async function () {
await esArchiver.load('empty_kibana');
await esArchiver.load('logstash_functional');
await esArchiver.load('getting_started/shakespeare');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need to load 'logstash_functional' and 'getting_started/shakespeare' data? I don't think importing the saved objects care if any data in any time range are used by the saved objects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found out that we have to load the data otherwise Kibana will crash.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised this bug - #97032

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review and discussed issues with Bhavya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test_xpack_functional v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants