-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for Importing saved objects from 6.x to 7.x #96869
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-qa (Team:QA) |
beforeEach(async function () { | ||
await esArchiver.load('empty_kibana'); | ||
await esArchiver.load('logstash_functional'); | ||
await esArchiver.load('getting_started/shakespeare'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need to load 'logstash_functional' and 'getting_started/shakespeare' data? I don't think importing the saved objects care if any data in any time range are used by the saved objects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We found out that we have to load the data otherwise Kibana will crash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised this bug - #97032
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - code review and discussed issues with Bhavya
This is part 2 for making sure users can import saved objects between versions. Its importing saved objects from 6.8.x to 7.x.
This PR handled it for 7.x to 8.0.0 #91908