[keystore] Fix openHandle in Jest tests #96671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` [2021-04-07T00:19:27Z] Jest did not exit one second after the test run has completed. [2021-04-07T00:19:27Z] [2021-04-07T00:19:27Z] This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue. ``` Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
tylersmalley
added
auto-backport
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
~/dev/kibana(pr/96671*) » node scripts/jest src/cli_keystore jon@xps
info yarn jest src/cli_keystore --config /home/jon/dev/kibana/src/cli_keystore/jest.config.js
PASS src/cli_keystore/utils/prompt.test.js
PASS src/cli_keystore/get_keystore.test.js (5.394 s)
PASS src/cli_keystore/list.test.js (5.422 s)
PASS src/cli_keystore/remove.test.js (5.447 s)
PASS src/cli_keystore/create.test.js (5.506 s)
PASS src/cli_keystore/add.test.js (5.613 s)
Test Suites: 6 passed, 6 total
Tests: 29 passed, 29 total
Snapshots: 0 total
Time: 7.381 s
Ran all test suites matching /src\/cli_keystore/i.
LGTM
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 13, 2021
``` [2021-04-07T00:19:27Z] Jest did not exit one second after the test run has completed. [2021-04-07T00:19:27Z] [2021-04-07T00:19:27Z] This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue. ``` Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Apr 13, 2021
``` [2021-04-07T00:19:27Z] Jest did not exit one second after the test run has completed. [2021-04-07T00:19:27Z] [2021-04-07T00:19:27Z] This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue. ``` Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where there are open handles present in the Keystore CLI unit tests.
sinon