Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] [Regression] Fix Top Hit / Filter Ratio aggregations #96288

Merged
merged 3 commits into from
Apr 7, 2021
Merged

[TSVB] [Regression] Fix Top Hit / Filter Ratio aggregations #96288

merged 3 commits into from
Apr 7, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Apr 6, 2021 •
edited
Loading

Summary

Regression of #92812. Valid only for master branch!

Steps to reproduce:

  1. Create a new TSVB visualization

  2. Open Panel options and set Kibana index pattern
    image
    Important: index should be selected

  3. Change aggregation from the default Count -> Top Hit
    image

@alexwizp alexwizp self-assigned this Apr 6, 2021
@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 labels Apr 6, 2021
@alexwizp alexwizp marked this pull request as ready for review April 6, 2021 10:37
@alexwizp alexwizp requested a review from a team April 6, 2021 10:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

stratoula
stratoula approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it locally and works fine

@stratoula
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@alexwizp
Copy link
Contributor Author

alexwizp commented Apr 7, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.6MB 1.6MB +64.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

VladLasitsa
VladLasitsa approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stratoula
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@alexwizp alexwizp merged commit 2efea06 into elastic:master Apr 7, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Apr 7, 2021
@alexwizp @kibanamachine
[TSVB] [Regression] Fix Top Hit / Filter Ratio aggregations (elastic#…
9a09dec 
…96288)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@alexwizp alexwizp mentioned this pull request Apr 7, 2021
Merged
alexwizp added a commit that referenced this pull request Apr 7, 2021
@alexwizp @kibanamachine
[TSVB] [Regression] Fix Top Hit / Filter Ratio aggregations (#96288) (#…
eb0e2db 
…96395)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladLasitsa VladLasitsa VladLasitsa approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

@alexwizp alexwizp

Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexwizp @elasticmachine @stratoula @kibanamachine @VladLasitsa