Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Added readonly toggle in cold phase #96036

Merged
merged 2 commits into from
Apr 7, 2021
Merged

[ILM] Added readonly toggle in cold phase #96036

merged 2 commits into from
Apr 7, 2021

Conversation

yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Apr 1, 2021 •
edited
Loading

Summary

Fixes #91957
This PR adds a switch for read only action to the cold phase in ILM.
Since a searchable snapshot is already read only, the read only action is not displayed in the warm and cold phases if the hot phases uses searchable snapshot.

Checklist

Release Note

When editing an ILM policy, there is now a toggle to make data read only in the cold phase.

@yuliacech yuliacech requested a review from a team as a code owner April 1, 2021 11:56
@yuliacech yuliacech added Feature:ILM release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@yuliacech yuliacech changed the title [ILM] Added readonly action in cold phase [ILM] Added readonly toggle in cold phase Apr 1, 2021
@yuliacech
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 236.9KB 237.5KB +638.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens
jloleysens approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code changes look good to me. Great to see how simple it is to add a new field :)

Thanks for adding this and great work @yuliacech !

@yuliacech yuliacech merged commit 011b234 into elastic:master Apr 7, 2021
@yuliacech yuliacech mentioned this pull request Apr 7, 2021
Merged
yuliacech added a commit to yuliacech/kibana that referenced this pull request Apr 7, 2021
@yuliacech @kibanamachine
Added readonly action in cold phase (elastic#96036)
eafcd1f 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
yuliacech added a commit that referenced this pull request Apr 7, 2021
@yuliacech @kibanamachine
Added readonly action in cold phase (#96036) (#96378)
eea2312 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@yuliacech yuliacech deleted the ilm_cold_readonly branch April 22, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
Feature:ILM release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support readonly action in the cold phase of ILM policies
4 participants
@yuliacech @elasticmachine @kibanamachine @jloleysens