[TSVB] Technical debt - remove default_index_pattern and default_timefield from model #95925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
force-pushed
the
remove_default_timefield
branch
from
74daefb
to
e2c3d3b
Compare
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
alexwizp
added
v7.13.0
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
stratoula
reviewed
Apr 7, 2021
| const visFields = await fetchFields(indexPatterns); | ||
|
|
||
| this.setState((state) => ({ | ||
| defaultIndex: index, | ||
| model: { | ||
| ...state.model, |
There was a problem hiding this comment.
I think that now can be simplifed to:
this.setState({
defaultIndex: index,
visFields,
});
You don't change something to model, so no need to update it, if I understand the code correctly
There was a problem hiding this comment.
good point! thank you
alexwizp
force-pushed
the
remove_default_timefield
branch
from
41dd230
to
809841d
Compare
stratoula
approved these changes
Apr 7, 2021
|
@elasticmachine run elasticsearch-ci/docs |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @alexwizp |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 7, 2021
…field from model (elastic#95925) * [TSVB] Technical debt - remove default_index_pattern and default_timefield from model * Update vis_editor.tsx Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
Apr 7, 2021
…field from model (#95925) (#96385) * [TSVB] Technical debt - remove default_index_pattern and default_timefield from model * Update vis_editor.tsx Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After saving TSVB rendering, two extra properties appear in the model:
default_index_pattern,default_timefieldThis is due to the fact that we get the default index in the parent component and then pass it through the model. It's wrong and this PR fix that.