Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Update mock and types #95771

Merged
merged 2 commits into from
Mar 30, 2021
Merged

[Lens] Update mock and types #95771

merged 2 commits into from
Mar 30, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Updated mock to be more test friendly and exported two types to be used in exploratory view.

@shahzad31 shahzad31 requested review from flash1293 and a team March 30, 2021 11:25
@shahzad31 shahzad31 self-assigned this Mar 30, 2021
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 30, 2021
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31 shahzad31 mentioned this pull request Mar 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

flash1293
flash1293 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks!

@flash1293 flash1293 added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 merged commit a154d92 into elastic:master Mar 30, 2021
@kibanamachine kibanamachine mentioned this pull request Mar 30, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 30, 2021
@shahzad31 @kibanamachine
update mock and types (elastic#95771)
a3d48c4
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #95810

This backport PR will be merged automatically after passing CI.

@shahzad31 shahzad31 deleted the update-lens-mock branch March 30, 2021 15:55
kibanamachine added a commit that referenced this pull request Mar 30, 2021
@kibanamachine @shahzad31
update mock and types (#95771) (#95810)
0f488c4 
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @kibanamachine @elasticmachine @flash1293