-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instances latency distribution chart tooltips and axis fixes #95577
Conversation
Pinging @elastic/apm-ui (Team:apm) |
retest |
...k/plugins/apm/public/components/shared/charts/instances_latency_distribution_chart/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/Main/route_config/index.tsx
Outdated
Show resolved
Hide resolved
import { PrimaryStatsServiceInstanceItem } from '../../../app/service_overview/service_overview_instances_chart_and_table'; | ||
import { CustomTooltip } from './custom_tooltip'; | ||
|
||
function getLatencyFormatter(props: TooltipInfo) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should ask the elastic charts team to make TooltipInfo
a generic so we can get better typing of datum
:
function getLatencyFormatter(props: TooltipInfo) { | |
function getLatencyFormatter(props: TooltipInfo<PrimaryStatsServiceInstanceItem>) { |
.../apm/public/components/shared/charts/instances_latency_distribution_chart/custom_tooltip.tsx
Outdated
Show resolved
Hide resolved
.../apm/public/components/shared/charts/instances_latency_distribution_chart/custom_tooltip.tsx
Show resolved
Hide resolved
I'm pretty late to the party here, but the overall tooltip and interactions look good to me as a first pass. I'm designing a more full-fledged interaction design to give a more clear definition of what I imagine should happen within the chart with selection and more. Would it be possible to add a small hint in the tooltip that the user can click and filter by the selected instance? E.g. "Click to filter by this instance" (someone has better copy?)? Happy to open this as an enhancement if it doesn't fit in right now. |
.../apm/public/components/shared/charts/instances_latency_distribution_chart/custom_tooltip.tsx
Show resolved
Hide resolved
...k/plugins/apm/public/components/shared/charts/instances_latency_distribution_chart/index.tsx
Outdated
Show resolved
Hide resolved
Good point! In the Metrics section we truncate the |
@smith I imagine something like this in the tooltip |
@formgeist in every case where we truncate now, you can see the full text in a tooltip when hovering. In this case we can't show a tooltip and you can't hover that name, so truncating it might hide information that you can't see in its expanded form. |
I'm fine with leaving it as-is for now |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…ax_primary_shard_size * 'master' of github.com:elastic/kibana: (99 commits) added missing optional chain for bracket notation (elastic#96939) [Discover][DocViewer] Fix toggle columns from doc viewer table tab (elastic#95748) [TSVB] Fix per-request caching of index patterns (elastic#97043) [Datatable] Fix filter cell flakiness (elastic#96934) Unskip heatmap suite and fixes flakiness (elastic#96941) [Fleet] Improve performance of data stream API (elastic#97058) [ML] Data Frame Analytics: remove beta badge (elastic#96977) [App Search] Migrate expanded rows for meta engines table in Engines Overview (elastic#96251) Instances latency distribution chart tooltips and axis fixes (elastic#95577) [Monitoring] Using primary average shard size (elastic#96177) [Workplace Search] Hide Kibana chrome on 3rd party connector redirects (elastic#97028) ## [Security Solution] Fixes `Exit full screen` and `Copy to cliboard` styling issues (elastic#96676) Index pattern field editor - Add warning on name or type change (elastic#95528) [App Search] Add small engine breadcrumb utility helper (elastic#96917) Copy esArchiver commands from ./reassign.ts to fix tests (elastic#97012) [Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (elastic#97011) Index patterns server - throw correct error on field caps 404 (elastic#95879) Use `EuiThemeProvider` in lists plugin tests and stories (elastic#96129) [npm] upgrade caniuse database (elastic#97002) chore(NA): moving @kbn/apm-utils into bazel (elastic#96227) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/serialization/policy_serialization.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts
…to-metrics-tab * 'master' of github.com:elastic/kibana: (61 commits) [Usage collection] Usage counters (elastic#96696) UI actions readme (elastic#96925) [TSVB] Enable brush for visualizations created with no index patterns (elastic#96727) [Data telemetry] Add Async Search to the tests (elastic#96693) added missing optional chain for bracket notation (elastic#96939) [Discover][DocViewer] Fix toggle columns from doc viewer table tab (elastic#95748) [TSVB] Fix per-request caching of index patterns (elastic#97043) [Datatable] Fix filter cell flakiness (elastic#96934) Unskip heatmap suite and fixes flakiness (elastic#96941) [Fleet] Improve performance of data stream API (elastic#97058) [ML] Data Frame Analytics: remove beta badge (elastic#96977) [App Search] Migrate expanded rows for meta engines table in Engines Overview (elastic#96251) Instances latency distribution chart tooltips and axis fixes (elastic#95577) [Monitoring] Using primary average shard size (elastic#96177) [Workplace Search] Hide Kibana chrome on 3rd party connector redirects (elastic#97028) ## [Security Solution] Fixes `Exit full screen` and `Copy to cliboard` styling issues (elastic#96676) Index pattern field editor - Add warning on name or type change (elastic#95528) [App Search] Add small engine breadcrumb utility helper (elastic#96917) Copy esArchiver commands from ./reassign.ts to fix tests (elastic#97012) [Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (elastic#97011) ...
Re-enable the instances latency distribution chart on the service overview.
When multiple instances are hovered it lists them separately:
The x-axis domain is customized to go from 0 to the max of the throughput values, so items don't display right on the origin.
Clicking on an item filters by putting the selected items in the kuery bar.
Create a
getServiceNodeName
helper that returns "(Empty)" if the value is_service_node_name_missing_
.Fixes #88852
Fixes #92631
Fixes #92870