Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @kbn/analytics to the dependencies in @kbn/ui-shared-deps #92202

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Feb 22, 2021

Summary

@afharo please make sure that @kbn/analytics is listed in the package.json file https://github.com/elastic/kibana/blob/master/packages/kbn-ui-shared-deps/package.json#L17 so that bootstrap knows to rebuild @kbn/ui-shared-deps when @kbn/analytics changes

Originally posted by @spalger in #91810 (comment)

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Feb 22, 2021
@afharo afharo requested a review from a team as a code owner February 22, 2021 15:32
@afharo afharo enabled auto-merge (squash) February 22, 2021 15:35
@afharo afharo added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 22, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit b1bbe16 into elastic:master Feb 22, 2021
@afharo afharo deleted the add-kbn-analytics-to-ui-shared-deps-package-json branch February 22, 2021 17:25
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #92244

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Feb 22, 2021
…2202) (#92244)

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants