Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOM] fix flaky suites #91809

Merged
merged 4 commits into from
Feb 18, 2021
Merged

[SOM] fix flaky suites #91809

merged 4 commits into from
Feb 18, 2021

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Feb 18, 2021

closes #89478
closes #68400

It seems that recent work on FTR and work on SOM routes fixed the flakyness of these issues. I'll be running the tests 3 times to make sure we are getting repeated successful builds

@Bamieh Bamieh added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 labels Feb 18, 2021
@Bamieh Bamieh requested a review from afharo February 18, 2021 11:52
@Bamieh Bamieh marked this pull request as ready for review February 18, 2021 11:52
@Bamieh
Copy link
Member Author

Bamieh commented Feb 18, 2021

@elasticmachine merge upstream

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. If CI goes constantly green, LGTM!

@Bamieh
Copy link
Member Author

Bamieh commented Feb 18, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit 386afdc into elastic:master Feb 18, 2021
@Bamieh Bamieh deleted the som/fix_flaky_tests branch February 18, 2021 16:34
@Bamieh Bamieh added v7.11.2 and removed v7.13.0 labels Feb 18, 2021
Bamieh added a commit to Bamieh/kibana that referenced this pull request Feb 18, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Bamieh added a commit that referenced this pull request Feb 18, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jbudz
Copy link
Member

jbudz commented Feb 19, 2021

I'm going to revert this change - we're seeing failures pop back up on #68400

jbudz added a commit that referenced this pull request Feb 19, 2021
jbudz added a commit that referenced this pull request Feb 19, 2021
Bamieh added a commit that referenced this pull request Feb 19, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Bamieh added a commit that referenced this pull request Feb 19, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 19, 2021
* master: (111 commits)
  [Logs UI] Replace dependencies in the infra bundle (elastic#91503)
  [Search Source] Do not request unmapped fields if source filters are provided (elastic#91921)
  [APM] Kql Search Bar suggests values outside the selected time range (elastic#91918)
  Refactored component edit policy tests into separate folders and using client integration testing setup (elastic#91657)
  [Fleet] Don't error on missing package_assets value (elastic#91744)
  [Lens] Pass used histogram interval to chart (elastic#91370)
  [Indexpattern management] Use indexPatterns Service instead of savedObjects client (elastic#91839)
  [Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific (elastic#91947)
  [CI] backportrc can skip CI (elastic#91886)
  Revert "[SOM] fix flaky suites (elastic#91809)"
  [Fleet] Install Elastic Agent integration by default during setup (elastic#91676)
  [Fleet] Silently swallow 404 errors when deleting ingest pipelines (elastic#91778)
  [data.search] Use incrementCounter for search telemetry (elastic#91230)
  [Fleet] Bootstrap functional test suite (elastic#91898)
  [Alerts][Docs] Added API documentation for alerts plugin (elastic#91067)
  Use correct environment in anomaly detection setup link (elastic#91877)
  [FTSR] Convert to tasks and add jest/api integration suites (elastic#91770)
  [CI] Build and publish storybooks (elastic#87701)
  docs: add PHP agent info to docs (elastic#91773)
  [DOCS] Adds and updates Visualization advanced settings (elastic#91904)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment