Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. #91787
[Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. #91787
Changes from 8 commits
1f4da90
9ac28bf
7f5af6f
ca27579
3b9fc72
6f08ff9
5674bcd
a8c2784
abe8b85
5a937a2
ff64031
125e4e8
a8bdeca
c8803ce
14839ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about removing the word "type" from the headings. I don't feel that it adds any value. So the navigation would look like this:
Index threshold
ES query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the geo alert be added to this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I spoke with Maps team and they want it to be separately, because they are planning more alerts types for Maps.
(cc @aaronjcaldwell )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this was awkward when I was doing the docs from the geo side too. On one hand, Geo Containment is a stack alert and I expect the next one, Geo Proximity, will be one too. It's possible we'll do more beyond this but that's TBD. They're distinct from other stack alerts in that they're geo-specific and require a Gold+ license, however I'm aware that's not something we need to distinguish in the docs. I guess I'm flexible in where and how we list them. @gchaps you probably have the best bird's eye view on docs. Any recommendations here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this PR out and then review the placement of the geo alert at a later date.