Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip functional skipped maps tests on 7.11 #90230

Closed
wants to merge 11 commits into from
Closed

Unskip functional skipped maps tests on 7.11 #90230

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9992cc4
unskip functional tests
rashmivkulkarni Jan 29, 2021
e5ada04
Merge branch '7.11' into unskip_functional_tests_which_are_skipped
kibanamachine Feb 2, 2021
d44f32d
unskipping tests
rashmivkulkarni Feb 2, 2021
84c902f
Merge branch 'unskip_functional_tests_which_are_skipped' of github.co…
rashmivkulkarni Feb 2, 2021
d151c9c
Merge branch '7.11' of github.com:elastic/kibana into unskip_function…
rashmivkulkarni Feb 3, 2021
baf3605
Merge branch '7.11' of github.com:elastic/kibana into unskip_function…
rashmivkulkarni Feb 3, 2021
43e3196
unskip maps functional tests
rashmivkulkarni Feb 3, 2021
7a8ce91
unskip maps functional tests
rashmivkulkarni Feb 3, 2021
166a884
Merge branch 'unskip_maps_tests' of github.com:rasroh/kibana into uns…
rashmivkulkarni Feb 3, 2021
af89056
fixed the errors
rashmivkulkarni Feb 4, 2021
91fbcba
updated the baseline session image from jenkins
rashmivkulkarni Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions x-pack/test/functional/apps/maps/layer_errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ import expect from '@kbn/expect';
export default function ({ getPageObjects }) {
const PageObjects = getPageObjects(['maps', 'header']);

// Failing: See https://github.com/elastic/kibana/issues/69617
describe.skip('layer errors', () => {
describe('layer errors', () => {
before(async () => {
await PageObjects.maps.loadSavedMap('layer with errors');
});
Expand Down Expand Up @@ -65,14 +64,15 @@ export default function ({ getPageObjects }) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/36011
describe.skip('EMSFileSource with missing EMS id', () => {
describe('EMSFileSource with missing EMS id', () => {
const MISSING_EMS_ID = 'idThatDoesNotExitForEMSFileSource';
const LAYER_NAME = 'EMS_vector_shapes';

it('should diplay error message in layer panel', async () => {
const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME);
expect(errorMsg).to.equal(`Unable to find EMS vector shapes for id: ${MISSING_EMS_ID}`);
expect(errorMsg).to.equal(
`Unable to find EMS vector shapes for id: ${MISSING_EMS_ID}. Kibana is unable to access Elastic Maps Service. Contact your systemadministrator.`
);
});

it('should allow deletion of layer', async () => {
Expand All @@ -89,7 +89,7 @@ export default function ({ getPageObjects }) {
it('should diplay error message in layer panel', async () => {
const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME);
expect(errorMsg).to.equal(
`Unable to find EMS tile configuration for id: ${MISSING_EMS_ID}`
`Unable to find EMS tile configuration for id: ${MISSING_EMS_ID}. Kibana is unable to access Elastic Maps Service. Contact your systemadministrator.`
);
});

Expand Down
12 changes: 3 additions & 9 deletions x-pack/test/functional/apps/maps/sample_data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ export default function ({ getPageObjects, getService, updateBaselines }) {
const PageObjects = getPageObjects(['common', 'maps', 'header', 'home', 'timePicker']);
const screenshot = getService('screenshots');

// FLAKY: https://github.com/elastic/kibana/issues/38137
describe.skip('maps loaded from sample data', () => {
describe('maps loaded from sample data', () => {
// Sample data is shifted to be relative to current time
// This means that a static timerange will return different documents
// Setting the time range to a window larger than the sample data set
Expand All @@ -21,13 +20,9 @@ export default function ({ getPageObjects, getService, updateBaselines }) {
past.setMonth(past.getMonth() - 6);
const future = new Date();
future.setMonth(future.getMonth() + 6);
await PageObjects.maps.setAbsoluteRange(
PageObjects.timePicker.formatDateToAbsoluteTimeString(past),
PageObjects.timePicker.formatDateToAbsoluteTimeString(future)
);
await PageObjects.maps.setAbsoluteRange(past.toISOString(), future.toISOString());
}

// Skipped because EMS vectors are not accessible in CI
describe('ecommerce', () => {
before(async () => {
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
Expand Down Expand Up @@ -59,7 +54,7 @@ export default function ({ getPageObjects, getService, updateBaselines }) {
'ecommerce_map',
updateBaselines
);
expect(percentDifference).to.be.lessThan(0.05);
expect(percentDifference).to.be.lessThan(0.06);
rashmivkulkarni marked this conversation as resolved.
Show resolved Hide resolved
});
});

Expand Down Expand Up @@ -94,7 +89,6 @@ export default function ({ getPageObjects, getService, updateBaselines }) {
});
});

// Skipped because EMS vectors are not accessible in CI
describe('web logs', () => {
before(async () => {
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
Expand Down