-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename PipelineProcessorsEditor to PipelineEditor to shorten import path to a length that Windows can handle #89645
Rename PipelineProcessorsEditor to PipelineEditor to shorten import path to a length that Windows can handle #89645
Conversation
…ath to a length that Windows can handle, and to disambiguate with child component of the same name.
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works locally after pulling the changes into #89505.
I'll wait for a merge to reflect the changes in the ingest_pipelines
migration to a TS project PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me @cjcenizal, I would like to add two items to this chore for consistency in naming. We should rename the following files + components too:
x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/pipeline_processors_editor_item
x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/pipeline_processors_editor_item_tooltip
I don't view these as blocking for this PR, but I think we should have a chore issue to address them if they if they are not going to be done in this PR.
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Thanks @jloleysens! I wasn't sure about those two, since there is a |
This change is intended to address #89505 (comment), in which the long names of our folders and files results in a path length error on Windows:
This change also disambiguates this component from a child component of the same name.