[Visualize] fix performance degradation after lodash@4 upgrade #75850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
reviewed
Aug 25, 2020
| @@ -41,7 +41,7 @@ export class VisConfig { | |||
|
|
|||
| const visType = visTypes[visConfigArgs.type]; | |||
| const typeDefaults = visType(visConfigArgs, this.data); | |||
| this._values = _.defaultsDeep({}, typeDefaults, DEFAULT_VIS_CONFIG); | |||
| this._values = _.defaultsDeep({ ...typeDefaults }, DEFAULT_VIS_CONFIG); | |||
There was a problem hiding this comment.
I thought we were going to add a special case to keep style parameters?
There was a problem hiding this comment.
Hey @majagrubic, it made sense when we wanted to change it for
this._values = {
... DEFAULT_VIS_CONFIG
...typeDefaults,
style:{
... DEFAULT_VIS_CONFIG.style
...typeDefaults.style,
}
}
but as I found a way to use defaultsDeep without perf degradation (not using 3 params but just two) the lodash function will do the above for free :)
majagrubic
approved these changes
Aug 25, 2020
This was referenced Aug 25, 2020
This was referenced Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After merging lodash 4, there was a significant performance degradation for visualize charts with many buckets.
Digging a bit deeper, I noticed that implementation of lodash
defaultsDeepchanged and causes issues when merging three objects (for area chart: 72 hours timepicker configured with y - count, x - date histogram on auto interval and split series with 5 buckets it increased from 0.7 ms to 400ms!).A simple solution is to copy
typeDefaultsobject and then run a function on a copy andDEFAULT_VIS_CONFIG. The behaviour is not changed.Here's before and after: