Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Explore underlying data" in-chart action #69494

Merged
merged 24 commits into from
Jun 26, 2020
Merged

"Explore underlying data" in-chart action #69494

merged 24 commits into from
Jun 26, 2020

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Jun 18, 2020

Summary

Part of #69368

Adds "Explore underlying data" action to visualization value click and brush triggers.

image

Checklist

For maintainers

@streamich streamich marked this pull request as ready for review June 25, 2020 10:18
@streamich streamich requested a review from a team June 25, 2020 10:18
@streamich streamich requested a review from a team as a code owner June 25, 2020 10:18
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jun 25, 2020
@streamich streamich added Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:skip Skip the PR/issue when compiling release notes review v7.9.0 v8.0.0 labels Jun 25, 2020
@streamich streamich requested a review from Dosant June 25, 2020 10:30
@streamich streamich requested a review from kertal June 25, 2020 10:30
@streamich streamich requested review from mdefazio and a team June 25, 2020 16:10
@streamich
Copy link
Contributor Author

streamich commented Jun 25, 2020

@elastic/kibana-design we preliminary agreed on above text ("Explore underlying data") and icon, but please comment if you think of better ones.

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp owned Code LGTM, tested locally in Chrome, Firefox, Safari, works 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
data 209 +3 206

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review.


One thing up to you, we can discuss:

I am not sure about new explicit dependency embeddable -> data because of trigger to filters helpers.

Because how many discussions we have today around this area and some changes are coming, I think I'd prefer it copy pasted for now.

@streamich streamich merged commit 684aa68 into elastic:master Jun 26, 2020
@streamich
Copy link
Contributor Author

@Dosant I'll rename to ChartTriggerContext in a follow up PR. Regarding triggers in embeddable plugin let's discuss that in the TSVB support meeting as I think it is related.

@elastic/kibana-design If you would like to change icon or text please ping me.

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 26, 2020
* master: (34 commits)
  Upgrade `elliptic` dependency (`6.5.2` → `6.5.3`). (elastic#70054)
  [License Management] Do not break when `telemetry.enabled:false` (elastic#69711)
  [SECURITY] Redirect app/security to app/security/overview (elastic#70005)
  "Explore underlying data" in-chart action (elastic#69494)
  Api reference docs for state_containers and state_sync (elastic#67354)
  prep state transfer for passing embeddables by value to editor and back (elastic#69991)
  move Metrics API to start (elastic#69787)
  refactor: 💡 fix typo in embeddable (elastic#69417)
  [alerting] migrates the old `alerting` consumer to be `alerts` (elastic#69982)
  [APM]Create API to return data to be used on the Overview page (elastic#69137)
  [Lens] Fix delete button position in dimension panel for long labels (elastic#69495)
  [Lens] Add toolbar api (elastic#69263)
  Fixes bug on color picker defaults on TSVB (elastic#69889)
  [DOCS] Fixes wording in Upload a CSV section (elastic#69969)
  [Discover] Validate timerange before submitting query to ES (elastic#69363)
  [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723)
  [Maps] Fix icon palettes are not working (elastic#69937)
  [Ingest Manager] Fix typo in constant name (elastic#69919)
  [test] skip status.allowAnonymous tests on cloud (elastic#69017)
  Fix backport (elastic#70003)
  ...
streamich added a commit that referenced this pull request Jun 26, 2020
* refactor: 💡 rename folder to "explore_data"

* style: 💄 check for "share" plugin in more semantic way

"explore data" actions use Discover URL generator, which is registered
in "share" plugin, which is optional plugin, so we check for its
existance, because otherwise URL generator is not available.

* refactor: 💡 move KibanaURL to a separate file

* feat: 🎸 add "Explore underlying data" in-chart action

* fix: 🐛 fix imports after refactor

* feat: 🎸 add start.filtersFromContext to embeddable plugin

* feat: 🎸 add type checkers to data plugin

* feat: 🎸 better handle empty filters in Discover URL generator

* feat: 🎸 implement .getUrl() method of explore data in-chart act

* feat: 🎸 add embeddable.filtersAndTimeRangeFromContext()

* feat: 🎸 improve getUrl() method of explore data action

* test: 💍 update test mock

* fix possible stale hashHistory.location in discover

* style: 💄 ensureHashHistoryLocation -> syncHistoryLocations

* docs: ✏️ update autogenerated docs

* test: 💍 add in-chart "Explore underlying data" unit tests

* test: 💍 add in-chart "Explore underlying data" functional tests

* test: 💍 clean-up custom time range after panel action tests

* chore: 🤖 fix embeddable plugin mocks

* chore: 🤖 fix another mock

* test: 💍 add support for new action to pie chart service

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embedding Embedding content via iFrame Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:skip Skip the PR/issue when compiling release notes review v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants