Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] APM TypeScript improvements (#68572) #68591

Merged
merged 1 commit into from
Jun 9, 2020
Merged

[7.x] APM TypeScript improvements (#68572) #68591

merged 1 commit into from
Jun 9, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Jun 8, 2020

Backports the following commits to 7.x:

@smith
APM TypeScript improvements (elastic#68572)
ff26b84 
* Add `compilerOptions.noErrorTrunctation` to the tsconfig template
* Remove unused parameters

Not adding `noUnusedParamaters` to the tsconfig since we get too many hits from dependencies when running `tsc`. These do show up in the editor as warnings, though.
@smith smith added the backport label Jun 8, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 5258a9b into elastic:7.x Jun 9, 2020
@smith smith deleted the backport/7.x/pr-68572 branch June 9, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smith @kibanamachine