Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run page_load_metrics tests in visual regresssion jobs #68570

Merged
merged 3 commits into from
Jun 9, 2020
Merged

run page_load_metrics tests in visual regresssion jobs #68570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e22880e
execute page_load_metrics tasks in visual baseline job
spalger Jun 9, 2020
9772a6f
replace Jenkinsfile for testing
spalger Jun 9, 2020
8afc5e6
Revert "replace Jenkinsfile for testing"
spalger Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/scripts/jenkins_visual_regression.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ mkdir -p "$installDir"
tar -xzf "$linuxBuild" -C "$installDir" --strip=1

echo " -> running visual regression tests from kibana directory"
checks-reporter-with-killswitch "X-Pack visual regression tests" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this job is actually run in a PR it fails because of the -- --, there's apparently too many or not enough escapes or something to pass through the -- just to the percy exec call, which requires it... Since the visual regression stuff isn't currently run in PRs I just removed the checks reporter here.

yarn percy exec -t 500 -- -- \
yarn percy exec -t 500 -- -- \
node scripts/functional_tests \
--debug --bail \
--kibana-install-dir "$installDir" \
Expand Down
6 changes: 4 additions & 2 deletions test/scripts/jenkins_xpack_visual_regression.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ tar -xzf "$linuxBuild" -C "$installDir" --strip=1

echo " -> running visual regression tests from x-pack directory"
cd "$XPACK_DIR"
checks-reporter-with-killswitch "X-Pack visual regression tests" \
yarn percy exec -t 500 -- -- \
yarn percy exec -t 500 -- -- \
node scripts/functional_tests \
--debug --bail \
--kibana-install-dir "$installDir" \
--config test/visual_regression/config.ts;

cd "$KIBANA_DIR"
source "test/scripts/jenkins_xpack_page_load_metrics.sh"