Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against disabled Dev Tools in legacy kibana/public/dev_tools. #66276

Merged
merged 1 commit into from
May 13, 2020
Merged

Guard against disabled Dev Tools in legacy kibana/public/dev_tools. #66276

merged 1 commit into from
May 13, 2020

Conversation

cjcenizal
Copy link
Contributor

@smith Reported disabling Dev Tools by setting dev_tools.enabled: false in kibana.yml and then seeing this fatal error:

image

This change fixes this.

Release note

Setting dev_tools.enabled: false in kibana.yml will no longer crash Kibana.

@cjcenizal cjcenizal added Feature:Dev Tools v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.8.0 v7.9.0 v7.7.1 labels May 12, 2020
@cjcenizal cjcenizal requested review from jloleysens and a team May 12, 2020 18:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@flash1293
Copy link
Contributor

flash1293 commented May 12, 2020 •
edited
Loading

Thanks for taking care of this, @cjcenizal . I am addressing this in the cutover PR which is moving dev tools to the new platform: #66276

This check will be part of the dev tools PR itself and thus won't trigger this exception anymore.

I got all necessary approvals and if everything goes as planned, I will merge this in tomorrow morning CET (just waiting another day so I'm available if problems occur).

Can we close this PR in favor of #66276 ?
Edit: Can we re-target this PR to just point to 7.8 and lower?

@cjcenizal cjcenizal changed the base branch from master to 7.8 May 12, 2020 18:34
@cjcenizal
Copy link
Contributor Author

Thanks @flash1293! Thanks for letting me know. I've retargeted 7.8.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens
jloleysens approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is the only place the code is called externally, fix looks good. Thanks @cjcenizal !

@cjcenizal cjcenizal merged commit 197d3b2 into elastic:7.8 May 13, 2020
@cjcenizal cjcenizal deleted the bug/disable-dev-tools branch May 13, 2020 22:12
@cjcenizal cjcenizal mentioned this pull request May 13, 2020
Merged
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request May 13, 2020
@cjcenizal
Guard against disabled Dev Tools in legacy kibana/public/dev_tools. (e…
591989d 
…lastic#66276)
cjcenizal added a commit that referenced this pull request May 14, 2020
@cjcenizal
[7.7] Guard against disabled Dev Tools in legacy kibana/public/dev_to…
38a0275 
…ols. (#66276) (#66494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
Feature:Dev Tools release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.7.1 v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjcenizal @elasticmachine @flash1293 @kibanamachine @jloleysens