-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against disabled Dev Tools in legacy kibana/public/dev_tools. #66276
Conversation
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Thanks for taking care of this, @cjcenizal . I am addressing this in the cutover PR which is moving dev tools to the new platform: #66276 This check will be part of the dev tools PR itself and thus won't trigger this exception anymore. I got all necessary approvals and if everything goes as planned, I will merge this in tomorrow morning CET (just waiting another day so I'm available if problems occur).
|
9a09dc9
to
367e005
Compare
Thanks @flash1293! Thanks for letting me know. I've retargeted 7.8. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is the only place the code is called externally, fix looks good. Thanks @cjcenizal !
@smith Reported disabling Dev Tools by setting
dev_tools.enabled: false
inkibana.yml
and then seeing this fatal error:This change fixes this.
Release note
Setting
dev_tools.enabled: false
inkibana.yml
will no longer crash Kibana.