Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes index mapping api response to plural form #66012

Merged
merged 3 commits into from
May 13, 2020
Merged

Changes index mapping api response to plural form #66012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bbacf6
changes index mapping api response to plural form
yuliacech May 11, 2020
65418ea
changes tab title to "Mappings" in Index Management detail panel
yuliacech May 12, 2020
dd8a4b6
updates index management jest snapshots for "Mappings" title
yuliacech May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/index_management/__jest__/components/__snapshots__/index_table.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion x-pack/plugins/index_management/__jest__/components/index_table.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ describe('index table', () => {
test('show settings button works from context menu', () => {
testEditor(0);
});
test('show mapping button works from context menu', () => {
test('show mappings button works from context menu', () => {
testEditor(1);
});
test('show stats button works from context menu', () => {
Expand Down
2 changes: 1 addition & 1 deletion ...index_management/public/application/sections/home/index_list/detail_panel/detail_panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const tabToHumanizedMap = {
<FormattedMessage id="xpack.idxMgmt.detailPanel.tabSettingsLabel" defaultMessage="Settings" />
),
[TAB_MAPPING]: (
<FormattedMessage id="xpack.idxMgmt.detailPanel.tabMappingLabel" defaultMessage="Mapping" />
<FormattedMessage id="xpack.idxMgmt.detailPanel.tabMappingLabel" defaultMessage="Mappings" />
),
[TAB_STATS]: (
<FormattedMessage id="xpack.idxMgmt.detailPanel.tabStatsLabel" defaultMessage="Stats" />
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/index_management/server/routes/api/mapping/register_mapping_route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ const paramsSchema = schema.object({
});

function formatHit(hit: { [key: string]: { mappings: any } }, indexName: string) {
const mapping = hit[indexName].mappings;
const mappings = hit[indexName].mappings;
return {
mapping,
mappings,
};
}

Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/api_integration/apis/management/index_management/mapping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default function({ getService }) {

const { body } = await getIndexMapping(index).expect(200);

expect(body.mapping).to.eql(mappings);
expect(body.mappings).to.eql(mappings);
});
});
}