[Discover] Remove column from sorting array when removed from table

[kertal]

Summary

When you removed a column in Discover, that was part of the sorting array, the sorting by this field was still active, and there was no way to remove it except modifying the URL. This caused confusion especially when you switched index pattern. The suggested solution is automatically removing the field from the sorting array, when you remove the column from the table.
Fixes #54345

How to test

• Add a column to to the doc table, sort by the column.
• Take a look at the URL, the field should be part of the sort: part.
• Remove the column.
• The URL should no longer contain the field in the sort: part.

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

[kertal]

@elasticmachine merge upstream

[kertal]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 01435b9

Build metrics

✅ unchanged

History

• 💚 Build #46954 succeeded db559b4
• 💔 Build #46864 failed aa6163d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[flash1293]

Tested, works as expected - removing a column which is sorted by and re-adding it will remove the sort. LGTM

Thanks for adding a functional test. It could be made slightly more stable by not checking the URL but whether the little triangle in the column header is not rendered after adding the column again. Not a blocker though.

[kertal]

thx @flash1293, good reminder about the potential flakiness, so I started a flaky test runner to be sure
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/557/ - it' s not flaky
I've implemented it that way because it also intially works when EuiDataGrid is introduced, I'll revisit it then 👍