Fix anomalies display on focused APM service map #65882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.
This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.
Make the transformation that add anomalies happen after the derived services nodes are added.
This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.
Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)
Fixes elastic#65403.
smith
added
bug
|
Pinging @elastic/apm-ui (Team:apm) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
May 8, 2020
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.
This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.
Make the transformation that add anomalies happen after the derived services nodes are added.
This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.
Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)
Fixes elastic#65403.
smith
added a commit
to smith/kibana
that referenced
this pull request
May 8, 2020
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.
This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.
Make the transformation that add anomalies happen after the derived services nodes are added.
This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.
Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)
Fixes elastic#65403.
smith
added a commit
that referenced
this pull request
May 8, 2020
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.
This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.
Make the transformation that add anomalies happen after the derived services nodes are added.
This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.
Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)
Fixes #65403.
smith
added a commit
that referenced
this pull request
May 8, 2020
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.
This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.
Make the transformation that add anomalies happen after the derived services nodes are added.
This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.
Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)
Fixes #65403.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 11, 2020
* master: (58 commits) [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628) fix double flyouts in add panel flow (elastic#65861) Point 7.x to 7.9.0 in .backportrc.json Mount ui/new_platform applications in same div structure as Core (elastic#63930) [Uptime] Settings threshold validation (elastic#65454) Fix edit alert flyout to update initialAlert after edit (elastic#65359) Fix anomalies display on focused APM service map (elastic#65882) [SIEM][Detection Engine] Increases the template limit for ECS mappings [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851) [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579) [ML] Add job timing stats to anomaly jobs (elastic#65696) restore index pattern management data-test-subj's (elastic#64697) [Discover] Prevent whitespace wrapping of doc table header (elastic#52861) [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789) Skipping failing tests. elastic#65867 elastic#65866 elastic#65865 [Discover] Deangularize the hits counter and create a react component (elastic#65631) Tsvb less update (elastic#65467) [TSVB] Remove remaining lodash.set usage (elastic#65846) [Uptime] Add `a11y` tests (elastic#65514) [Uptime] Enable loading on monitor list (elastic#65670) ...
|
Tested:
|
cauemarcondes
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.
This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.
Make the transformation that add anomalies happen after the derived services nodes are added.
This is done in the function that was called
dedupeConnections, but since it does much more than dedupe connections has been renamed totransformServiceMapResponses.Also make the node types extend
cytoscape.NodeDataDefinitionin order to simplify the types in the transformation (we were adding& { id: string }in some places which this replaces.)Fixes #65403.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers