Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [CANVAS] Moves notify to a canvas service (#63268) #64666

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Apr 28, 2020

Backports the following commits to 7.x:

* Moves notify to a canvas service

* Typecheck fix
@crob611
Copy link
Contributor Author

crob611 commented Apr 29, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Plugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/event_log/public_api_integration·ts.event_log Event Log public API should support pagination for events

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: event_log
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: Event Log public API
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> should allow querying for events by Saved Object
[00:00:00]               └-> "before each" hook: global before each
[00:00:00]               │ debg Logging Event for Saved Object 63d312e1-2524-4f10-a35d-a4ed88d11fcd
[00:00:00]               │ proc [kibana]   log   [14:57:10.167] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 63d312e1-2524-4f10-a35d-a4ed88d11fcd {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"63d312e1-2524-4f10-a35d-a4ed88d11fcd"}]},"message":"test 2020-04-29T14:57:10.096Z"}
[00:00:00]               │ proc [kibana]   log   [14:57:10.198] [info][eventLogFixture][event_log_fixture][plugins][plugins] log event error: Error: Saved object [event_log_test/63d312e1-2524-4f10-a35d-a4ed88d11fcd] not found
[00:00:00]               │ proc [kibana]   log   [14:57:10.642] [info][eventLogFixture][event_log_fixture][plugins][plugins] created saved object
[00:00:00]               │ proc [kibana]   log   [14:57:10.644] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:00]               │ debg Logging Event for Saved Object 63d312e1-2524-4f10-a35d-a4ed88d11fcd
[00:00:00]               │ proc [kibana]   log   [14:57:10.646] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"63d312e1-2524-4f10-a35d-a4ed88d11fcd"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:10.096Z","@timestamp":"2020-04-29T14:57:10.643Z","ecs":{"version":"1.5.0"}}
[00:00:00]               │ proc [kibana]   log   [14:57:10.731] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 63d312e1-2524-4f10-a35d-a4ed88d11fcd {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"63d312e1-2524-4f10-a35d-a4ed88d11fcd"}]},"message":"test 2020-04-29T14:57:10.096Z"}
[00:00:00]               │ proc [kibana]   log   [14:57:10.772] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:00]               │ proc [kibana]   log   [14:57:10.773] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:00]               │ debg calling /api/event_log/event_log_test/63d312e1-2524-4f10-a35d-a4ed88d11fcd/_find
[00:00:00]               │ proc [kibana]   log   [14:57:10.775] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"63d312e1-2524-4f10-a35d-a4ed88d11fcd"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:10.096Z","@timestamp":"2020-04-29T14:57:10.772Z","ecs":{"version":"1.5.0"}}
[00:00:00]               │ debg --- retry.try error: expected 0 to equal 2
[00:00:01]               │ debg calling /api/event_log/event_log_test/63d312e1-2524-4f10-a35d-a4ed88d11fcd/_find
[00:00:01]               └- ✓ pass  (1.4s) "event_log Event Log public API should allow querying for events by Saved Object"
[00:00:01]             └-> should support pagination for events
[00:00:01]               └-> "before each" hook: global before each
[00:00:01]               │ debg Logging Event for Saved Object ecb1427b-0d04-4072-9522-0f9fca65fd62
[00:00:01]               │ proc [kibana]   log   [14:57:11.611] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: ecb1427b-0d04-4072-9522-0f9fca65fd62 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}]},"message":"test 2020-04-29T14:57:11.543Z"}
[00:00:01]               │ proc [kibana]   log   [14:57:11.635] [info][eventLogFixture][event_log_fixture][plugins][plugins] log event error: Error: Saved object [event_log_test/ecb1427b-0d04-4072-9522-0f9fca65fd62] not found
[00:00:02]               │ proc [kibana]   log   [14:57:12.664] [info][eventLogFixture][event_log_fixture][plugins][plugins] created saved object
[00:00:02]               │ proc [kibana]   log   [14:57:12.665] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ debg Logging Event for Saved Object ecb1427b-0d04-4072-9522-0f9fca65fd62
[00:00:02]               │ debg Logging Event for Saved Object ecb1427b-0d04-4072-9522-0f9fca65fd62
[00:00:02]               │ debg Logging Event for Saved Object ecb1427b-0d04-4072-9522-0f9fca65fd62
[00:00:02]               │ debg Logging Event for Saved Object ecb1427b-0d04-4072-9522-0f9fca65fd62
[00:00:02]               │ debg Logging Event for Saved Object ecb1427b-0d04-4072-9522-0f9fca65fd62
[00:00:02]               │ proc [kibana]   log   [14:57:12.667] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:11.543Z","@timestamp":"2020-04-29T14:57:12.665Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [14:57:12.823] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: ecb1427b-0d04-4072-9522-0f9fca65fd62 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}]},"message":"test 2020-04-29T14:57:11.543Z"}
[00:00:02]               │ proc [kibana]   log   [14:57:12.831] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: ecb1427b-0d04-4072-9522-0f9fca65fd62 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}]},"message":"test 2020-04-29T14:57:11.544Z"}
[00:00:02]               │ proc [kibana]   log   [14:57:12.840] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: ecb1427b-0d04-4072-9522-0f9fca65fd62 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}]},"message":"test 2020-04-29T14:57:11.544Z"}
[00:00:02]               │ proc [kibana]   log   [14:57:12.850] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: ecb1427b-0d04-4072-9522-0f9fca65fd62 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}]},"message":"test 2020-04-29T14:57:11.543Z"}
[00:00:02]               │ proc [kibana]   log   [14:57:12.871] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: ecb1427b-0d04-4072-9522-0f9fca65fd62 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}]},"message":"test 2020-04-29T14:57:11.544Z"}
[00:00:02]               │ proc [kibana]   log   [14:57:12.873] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:02]               │ proc [kibana]   log   [14:57:12.874] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ proc [kibana]   log   [14:57:12.876] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:02]               │ proc [kibana]   log   [14:57:12.877] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ proc [kibana]   log   [14:57:12.878] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:02]               │ proc [kibana]   log   [14:57:12.881] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ proc [kibana]   log   [14:57:12.884] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:11.543Z","@timestamp":"2020-04-29T14:57:12.874Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [14:57:12.884] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:11.544Z","@timestamp":"2020-04-29T14:57:12.876Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [14:57:12.885] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:11.544Z","@timestamp":"2020-04-29T14:57:12.879Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [14:57:12.889] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:02]               │ proc [kibana]   log   [14:57:12.890] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ proc [kibana]   log   [14:57:12.892] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:11.543Z","@timestamp":"2020-04-29T14:57:12.890Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [14:57:12.895] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:02]               │ proc [kibana]   log   [14:57:12.896] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ debg calling /api/event_log/event_log_test/ecb1427b-0d04-4072-9522-0f9fca65fd62/_find
[00:00:02]               │ proc [kibana]   log   [14:57:12.899] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:11.544Z","@timestamp":"2020-04-29T14:57:12.895Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ debg --- retry.try error: expected 0 to equal 6
[00:00:03]               │ debg calling /api/event_log/event_log_test/ecb1427b-0d04-4072-9522-0f9fca65fd62/_find
[00:00:03]               │ debg calling /api/event_log/event_log_test/ecb1427b-0d04-4072-9522-0f9fca65fd62/_find?per_page=3
[00:00:03]               │ debg failed to match {"foundEvents":[{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:11.543Z","@timestamp":"2020-04-29T14:57:12.665Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:11.543Z","@timestamp":"2020-04-29T14:57:12.874Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T14:57:11.544Z","@timestamp":"2020-04-29T14:57:12.876Z","ecs":{"version":"1.5.0"}}],"expectedEvents":[{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}]},"message":"test 2020-04-29T14:57:11.543Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}]},"message":"test 2020-04-29T14:57:11.543Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ecb1427b-0d04-4072-9522-0f9fca65fd62"}]},"message":"test 2020-04-29T14:57:11.543Z"}]}
[00:00:03]               └- ✖ fail: "event_log Event Log public API should support pagination for events"
[00:00:03]               │

Stack Trace

{ Error: expected 'test 2020-04-29T14:57:11.544Z' to sort of equal 'test 2020-04-29T14:57:11.543Z'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at forEach (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:179:40)
    at Array.forEach (<anonymous>)
    at assertEventsFromApiMatchCreatedEvents (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:176:19)
    at Context.it (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:70:7)
  actual: 'test 2020-04-29T14:57:11.544Z',
  expected: 'test 2020-04-29T14:57:11.543Z',
  showDiff: true }

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 merged commit 1717736 into elastic:7.x Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants