Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Make average the default metric when dragging a field directly #63416

Merged
merged 3 commits into from
Apr 16, 2020

Conversation

wylieconlon
Copy link
Contributor

Fixes a bug in Lens where the "Minimum" metric was being selected instead of the "Average" metric when the user drags a field directly into a dimension like the Y-axis.

The bug was caused by using inconsistent logic in our datasource, so the fix is to make the logic a bit more consistent within the datasource.

Fixes #58331

Checklist

@wylieconlon wylieconlon added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.8.0 labels Apr 13, 2020
@wylieconlon wylieconlon requested review from timroes, mbondyra and a team April 13, 2020 22:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally on Chrome, code looks good 🆗

@mbondyra
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon wylieconlon merged commit 13422b8 into elastic:master Apr 16, 2020
@wylieconlon wylieconlon deleted the lens/fix-suggestions-on-drop branch April 16, 2020 14:34
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Apr 16, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
wylieconlon pushed a commit that referenced this pull request Apr 16, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Dropping numerical field into dimension wrongly select Minimum aggregation
4 participants