Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NP] Get rid of ui/i18n in Discover #62799

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

maryia-lapata
Copy link
Contributor

Summary

Part of #60097.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@maryia-lapata maryia-lapata added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.8.0 labels Apr 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this pull request Apr 7, 2020
69 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@maryia-lapata maryia-lapata marked this pull request as ready for review April 8, 2020 06:17
@maryia-lapata maryia-lapata requested a review from a team April 8, 2020 06:17
@kertal
Copy link
Member

kertal commented Apr 8, 2020

@maryia-lapata thx! ACK, will review today

@@ -201,7 +201,6 @@ function createDocTableModule() {
.directive('docTable', createDocTableDirective)
.directive('kbnTableHeader', createTableHeaderDirective)
.directive('toolBarPagerText', createToolBarPagerTextDirective)
.directive('toolBarPagerText', createToolBarPagerTextDirective)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for cleaning this up !

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and couldn't find any problems, LGTM.

A side note: To also have phrases within EUI components translated properly (e.g. for the EuiBasicTable component), everything should theoretically be wrapped into a I18nContext returned from core.i18n.Context. In this particular case I couldn't find an instance of this, so this looks good to me for now (especially since passing down the context component will be a lot of work as they are a lot of roots).

When we are denagularizing the rest of the application, it will be sufficient to place a single I18nContext in the root of the react app.

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 , thx for the cleanups! Tested locally in Chrome 80, macOs 10.14.6
✅ Discover Main
✅ Discover Context
✅ Discover Doc view
All work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants