Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set initial nav drawer isLocked state in Header constructor #61338

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Set initial nav drawer isLocked state in Header constructor #61338

merged 2 commits into from
Mar 25, 2020

Conversation

cjcenizal
Copy link
Contributor

Fixes #60806

@cjcenizal cjcenizal added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.7.0 v7.8.0 labels Mar 25, 2020
@cjcenizal cjcenizal requested a review from a team as a code owner March 25, 2020 18:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal merged commit 8eaed26 into elastic:master Mar 25, 2020
@cjcenizal cjcenizal deleted the bug/nav-drawer-initial-locked-state branch March 25, 2020 21:42
@cjcenizal cjcenizal mentioned this pull request Mar 25, 2020
Merged
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Mar 25, 2020
@cjcenizal
Set initial nav drawer isLocked state in Header constructor (elastic#…
e21e95d 
…61338)
@cjcenizal cjcenizal mentioned this pull request Mar 25, 2020
Merged
@ryankeairns
Copy link
Contributor

Thanks for fixing this @cjcenizal !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdover joshdover joshdover approved these changes

@myasonik myasonik myasonik approved these changes

@ryankeairns ryankeairns Awaiting requested review from ryankeairns

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nav drawer doesn't respect initial locked state
6 participants
@cjcenizal @elasticmachine @kibanamachine @ryankeairns @joshdover @myasonik