Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] service maps: avoid unnecesary useDeepObjectIdentity #60836

Merged

Conversation

sorenlouv
Copy link
Member

Minor improvement to service maps data fetching

@sorenlouv sorenlouv requested a review from a team as a code owner March 20, 2020 23:39
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I think I forgot this when removing the pagination. Did you figure out how exactly environment works for the service map queries?

@sorenlouv
Copy link
Member Author

Thanks - I think I forgot this when removing the pagination. Did you figure out how exactly environment works for the service map queries?

I didn't look into that yet. Just wanted to get this minor thing out of the way.

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 21, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit d3a9531 into elastic:master Mar 21, 2020
@sorenlouv sorenlouv deleted the avoid-unneeded-useDeepObjectIdentity branch March 21, 2020 20:41
sorenlouv added a commit that referenced this pull request Mar 21, 2020
…#60861)

* [APM] service maps: avoid unnecesary `useDeepObjectIdentity`

* Remove unused dep
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 23, 2020
* master: (39 commits)
  [APM]Create custom link from Trace summary (elastic#59648)
  [ML] Fixing app clean up (elastic#60853)
  [SIEM] Use ECS categorisation for Authentication widgets (elastic#60734)
  [NP] Remove kbnUrl usage in discover/dashboard/visualize (elastic#60016)
  Skip failing test
  [Uptime]Update fetch effect failed action handling (elastic#60742)
  [npm] upgrade elastic/maki (elastic#60829)
  [Uptime] Add Settings Page (elastic#53550)
  [APM] service maps: avoid unnecesary `useDeepObjectIdentity` (elastic#60836)
  [Index management] Re-enable index template tests (elastic#60780)
  Fixed UI/UX issues: alerts delete confirmation, combobox behaviors (elastic#60703)
  [SIEM] Fix patching of ML Rules (elastic#60830)
  [APM] Service Map - Separate overlapping edges by rotating nodes (elastic#60477)
  [Alerting] fix flaky test for index threshold grouping (elastic#60792)
  [SIEM][Detection Engine] Adds test scripts for machine learning feature
  Flatten child api response for resolver (elastic#60810)
  Change "url" to "urls" in APM agent instructions (elastic#60790)
  [DOCS] Updates API requests and examples (elastic#60695)
  [SIEM] [Cases] Create case from timeline (elastic#60711)
  [Lens] Resetting a layer generates new suggestions (elastic#60674)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants