Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Fix percentiles band mode #60741

Merged
merged 5 commits into from
Mar 23, 2020
Merged

[TSVB] Fix percentiles band mode #60741

merged 5 commits into from
Mar 23, 2020

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Mar 20, 2020 •
edited
Loading

Summary

Fixes #58840
Fixes #34943

Make TSVB supports Band mode with Percentile metric:

image

This also adds support of bar chart type in Band mode (was not presented in earlier versions):

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sulemanof sulemanof marked this pull request as ready for review March 20, 2020 14:23
@sulemanof sulemanof added Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0 labels Mar 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

markov00
markov00 approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, checked locally and seems to work correctly, band area chart and bar chart shown fine.

I'd like to suggest two small changes to apply that will provide a nice addition:

  • the Fill to input should be limited to into the domain of 0, 100. More than 100 result in error on the chart that can be avoided if possible

Screenshot 2020-03-20 at 17 15 27

  • the legend is correctly showing the upper and lower bound of the area, but we have a set of props on the AreaSeries,BarSeries components that allows you to fix the legend items into two nicer legend items.
    The current visualization shows:

Screenshot 2020-03-20 at 17 15 41

Instead you can configure the series name without the (50) value and add the values of the upper and lower bound in the following props:

y1AccessorFormat=" (50)" 
y0AccessorFormat=" (10)"

like
Screenshot 2020-03-20 at 17 45 47

see https://elastic.github.io/elastic-charts/?path=/story/area-chart--band-area&knob-scale to extent=true&knob-y0AccessorFormat= (50)&knob-y1AccessorFormat= (10) for an example

@sulemanof
Copy link
Contributor Author

sulemanof commented Mar 23, 2020 •
edited
Loading

Hey @markov00 !

I'd like to suggest two small changes to apply that will provide a nice addition:

Thanks for suggestions, I updated the PR due to recommendations!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit 1b583a2 into elastic:master Mar 23, 2020
@sulemanof sulemanof deleted the fix/tsvb_percentiles branch March 23, 2020 15:42
@sulemanof sulemanof mentioned this pull request Mar 23, 2020
Merged
sulemanof added a commit to sulemanof/kibana that referenced this pull request Mar 23, 2020
@sulemanof
[TSVB] Fix percentiles band mode (elastic#60741)
b12eb8e 
* Fix percentiles band mode

* Add support of bar chart, fix tests

* Use accessor formatters

* Fix tests
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 23, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
d4ed23c 
* master:
  [Uptime] Skip failing location test temporarily (elastic#60938)
  [ML] Disabling datafeed editing when job is running (elastic#60751)
  Adding `authc.invalidateAPIKeyAsInternalUser` (elastic#60717)
  [SIEM] Add license check to ML Rule form (elastic#60691)
  Adding `authc.grantAPIKeyAsInternalUser`  (elastic#60423)
  Support Histogram Data Type (elastic#59387)
  [Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (elastic#60770)
  [SIEM] [Cases] Update case icons (elastic#60812)
  [TSVB] Fix percentiles band mode (elastic#60741)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 23, 2020
@gmmorris
Merge branch 'master' into alerting/details-cleanup
5897883 
* master: (26 commits)
  [Alerting] Fixes flaky test in Alert Instances Details page (elastic#60893)
  cleanup visualizations api (elastic#59958)
  Inline timezoneProvider function, remove ui/vis/lib/timezone  (elastic#60475)
  [SIEM] Adds 'Open one signal' Cypress test (elastic#60484)
  [UA] Upgrade assistant migration meta data can become stale (elastic#60789)
  [Metrics Alerts] Remove metric field from doc count on backend (elastic#60679)
  [Uptime] Skip failing location test temporarily (elastic#60938)
  [ML] Disabling datafeed editing when job is running (elastic#60751)
  Adding `authc.invalidateAPIKeyAsInternalUser` (elastic#60717)
  [SIEM] Add license check to ML Rule form (elastic#60691)
  Adding `authc.grantAPIKeyAsInternalUser`  (elastic#60423)
  Support Histogram Data Type (elastic#59387)
  [Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (elastic#60770)
  [SIEM] [Cases] Update case icons (elastic#60812)
  [TSVB] Fix percentiles band mode (elastic#60741)
  Fix formatter on range aggregation (elastic#58651)
  Goodbye, legacy data plugin 👋 (elastic#60449)
  [Metrics UI] Alerting for metrics explorer and inventory (elastic#58779)
  [Remote clustersadopt changes to remote info API (elastic#60795)
  Only run xpack siem cypress in PRs when there are siem changes (elastic#60661)
  ...
sulemanof added a commit that referenced this pull request Mar 24, 2020
@sulemanof
[TSVB] Fix percentiles band mode (#60741) (#60924)
4f18236 
* Fix percentiles band mode

* Add support of bar chart, fix tests

* Use accessor formatters

* Fix tests
@sulemanof sulemanof mentioned this pull request Apr 24, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

@timroes timroes Awaiting requested review from timroes

Assignees
No one assigned
Labels
backported Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSVB percentage band completely broken [TSVB] missing legend items for percentile in band mode
4 participants
@sulemanof @elasticmachine @kibanamachine @markov00