Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix bug when removing dimensions from non-XY chart #60704

Merged
merged 1 commit into from
Mar 20, 2020
Merged

[Lens] Fix bug when removing dimensions from non-XY chart #60704

merged 1 commit into from
Mar 20, 2020

Conversation

wylieconlon
Copy link
Contributor

Summary

A one-line scope issue caused a crash when removing a dimension from a chart like Table or Metric, because the wrong state was being used in suggestions.

Fixes #60404

Checklist

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.7.0 labels Mar 19, 2020
@wylieconlon wylieconlon requested review from timroes, mbondyra and a team March 19, 2020 21:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

timroes
timroes approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@wylieconlon wylieconlon merged commit 6d1479f into elastic:master Mar 20, 2020
@wylieconlon wylieconlon deleted the lens/fix-dimension-remove branch March 20, 2020 18:59
@wylieconlon wylieconlon mentioned this pull request Mar 20, 2020
Merged
wylieconlon pushed a commit that referenced this pull request Mar 20, 2020
[Lens] Fix bug when removing dimensions from non-XY chart (#60704) (#…
c0f9017 
…60794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Removing a dimension in the table crashes the app
5 participants
@wylieconlon @elasticmachine @kibanamachine @timroes @mbondyra