Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Fixes Modification of ML Rules #60662

Merged
merged 6 commits into from
Mar 20, 2020
Merged

[SIEM] Fixes Modification of ML Rules #60662

merged 6 commits into from
Mar 20, 2020

Commits on Mar 19, 2020

  1. Fixe updating of ML rules 

    * This wasn't caught by typescript
* We should add a unit test to catch this
the other routes besides create probably are similarly broken.
    @rylnd
    rylnd committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    28d02fa View commit details
    Browse the repository at this point in the history

  2. Add a regression test for updating ML Rules

    @rylnd
    rylnd committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    c018814 View commit details
    Browse the repository at this point in the history

  3. Allow ML Rules to be patched 

    And adds a regression unit test.
    @rylnd
    rylnd committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    7ee9da4 View commit details
    Browse the repository at this point in the history

  4. Allow ML rule params to be imported when overwriting

    @rylnd
    rylnd committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    19c9e1a View commit details
    Browse the repository at this point in the history

  5. Add a basic regression test for creating a rule with ML params

    @rylnd
    rylnd committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    a2a0d0c View commit details
    Browse the repository at this point in the history

  6. Prevent users from changing an existing Rule's type

    @rylnd
    rylnd committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    9341e06 View commit details
    Browse the repository at this point in the history