Enhancement/update esdocs datasource

[maggieghamry]

Summary

• Fixes [Canvas] Add a 'Basic' data source #53200
• Update to add accordion for "advanced settings" in the Elasticsearch raw documents datasource data section
• Updated warning verbiage per Ryan's specifications
• The warning can't be easily moved below the "preview" and "save" buttons, as that is a shared datasource component across all datasources (so would be seen across all, without some additional work).
• It may be beneficial to sync with Kaarina to get documentation for the datasource panel, warning box, and the specific link that the "lucene query string syntax" text should link to (I think having a link to the documentation would be helpful, perhaps this link or this link
• Images:
  
  
  Updated Datasource Order:
  

Checklist

Delete any items that are not applicable to this PR.

• [x ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• [ x] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-canvas (Team:Canvas)

[ryankeairns]

@maggieghamry I think this PR needs rebased to the latest from master. When starting it up, it asked me to use node version 10.18.0 which tipped me off since master is running 10.19.0.

[poffdeluxe]

lgtm -- seemed to work well

[ryankeairns]

The general layout and interaction is looking good, some little design tweaks for the accordion are needed, but that's easy enough to address.

I'm not having any luck getting the data to render in the element. The preview modal shows the data, but no data is being returned to the element after I select the fields (e.g. metric always displays zero; data tables are blank).

It's off to a good start! I'll check again once this has been updated with latest from master and the checklist from the original is complete.

Thanks!

[maggieghamry]

The general layout and interaction is looking good, some little design tweaks for the accordion are needed, but that's easy enough to address.

I'm not having any luck getting the data to render in the element. The preview modal shows the data, but no data is being returned to the element after I select the fields (e.g. metric always displays zero; data tables are blank).

It's off to a good start! I'll check again once this has been updated with latest from master and the checklist from the original is complete.

Thanks!

@ryankeairns the latest is based on your checklist - can you let me know what you're seeing that's not working?

[maggieghamry]

@maggieghamry I think this PR needs rebased to the latest from master. When starting it up, it asked me to use node version 10.18.0 which tipped me off since master is running 10.19.0.

Hmm, interesting - I checked out a fresh master copy and branched off of that for this branch. I can pull the latest.

[ryankeairns]

@maggieghamry I'll check it out again. I'm going by the checklist here, looks like there several items left:

#53200 (comment)

[ryankeairns]

This is coming along nicely!

Here are the few outstanding items that I see:

• the last two checklist items (re: title sizes on cards and what to call this data source)
• working in Kaarina's feedback
• there's some tight spacing with the new accordion. Specifically, it needs some margin before and after along with a border along the top. I'm happy to provide a design PR/commit if that's helpful

This is going to be a great improvement :)

[ryankeairns]

@maggieghamry I created a design PR against your branch with a few small changes.

1. 👉 You can click the merge button at any time to pull those in: Design tweaks for esdocs datasource PR maggieghamry/kibana#2

2. As for the doc link question you had on Friday, you can see an example of how that can be added to an EuiFormRow > labelAppend here (from the ES SQL data source):

kibana/x-pack/legacy/plugins/canvas/canvas_plugin_src/uis/datasources/essql.js

Lines 62 to 72 in 92cc04c

	<EuiFormRow
	isInvalid={isInvalid}
	label={strings.getLabel()}
	labelAppend={
	<EuiText size="xs">
	<EuiLink href={SQL_URL} target="_blank">
	{strings.getLabelAppend()}
	</EuiLink>
	</EuiText>
	}
	>

[maggieghamry]

@elasticmachine merge upstream

[maggieghamry]

@elasticmachine merge upstream

[maggieghamry]

I noticed we are always using the "Database" icon in the link back to the list of datasources.

Should we switch that to match the icon for whatever the datasource is? (Maybe a follow up PR)

@crob611 I had an aha moment waiting for the tests to run, and got this working as well

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: ba95628

History

• 💔 Build #34370 failed e44347f
• 💔 Build #34355 failed 5bdb2c1
• 💔 Build #34333 failed 0f4fb1f
• 💔 Build #34314 failed 8840013
• 💔 Build #34277 failed af4694d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream