Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Kibana Login Selector #53010

Merged
merged 16 commits into from
Mar 23, 2020
Merged

Implement Kibana Login Selector #53010

merged 16 commits into from
Mar 23, 2020

Commits on Mar 10, 2020

  1. Introduce Login Selector functionality.

    @azasypkin
    azasypkin committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f442437 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Merge branch 'master' into issue-xxx-cloud-sso

    @azasypkin
    azasypkin committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    d89ab88 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Merge branch 'master' into issue-xxx-cloud-sso

    @azasypkin
    azasypkin committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    5253fc7 View commit details
    Browse the repository at this point in the history

  2. Review#1: introduce showInSelector config value, properly handle de… 

    …fault value of `selector.enabled`, improve redirect URL handling.
    @azasypkin
    azasypkin committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    d6d4c2d View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Review#2: new unit tests, return response headers from login_with if … 

    …provided by the authentication result, make `redirectURLPath` required in user initiated OIDC login attempt, handle part of the review feedback.
    @azasypkin
    azasypkin committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    a572c52 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Merge branch 'master' into issue-xxx-cloud-sso

    @azasypkin
    azasypkin committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    706748a View commit details
    Browse the repository at this point in the history

  2. Review#3: move Login selector logic into LoginForm component.

    @azasypkin
    azasypkin committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    5b189c2 View commit details
    Browse the repository at this point in the history

  3. Review#3: rename BasicLoginForm to LoginForm component.

    @azasypkin
    azasypkin committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    db2f4b3 View commit details
    Browse the repository at this point in the history

  4. Review#3: add initial set of Login Selector API integration tests.

    @azasypkin
    azasypkin committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    aae6867 View commit details
    Browse the repository at this point in the history

  5. Review#3: rely on serverBasePath provided by the core for the consist… 

    …ency sake.
    @azasypkin
    azasypkin committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    1204619 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Merge branch 'master' into issue-xxx-cloud-sso

    @azasypkin
    azasypkin committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    181c6db View commit details
    Browse the repository at this point in the history

  2. Review#4: remove wrong test comment, add more tests for the `LoginFor… 

    …m` component and `Authenticator`, add additional integration test for Keberos when client provides certificate, fix other nits.
    @azasypkin
    azasypkin committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    37c6489 View commit details
    Browse the repository at this point in the history

  3. Review#5: use EuiSpacer instead of CSS margin.

    @azasypkin
    azasypkin committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    f6b1d4f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into issue-xxx-cloud-sso

    @azasypkin
    azasypkin committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    c197b9c View commit details
    Browse the repository at this point in the history

  5. Integrate latest upstream changes after master merge.

    @azasypkin
    azasypkin committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    aed4521 View commit details
    Browse the repository at this point in the history

  6. Review#5: remove redundant user icon from login selector button.

    @azasypkin
    azasypkin committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    ceba57b View commit details
    Browse the repository at this point in the history