Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code] disk watermark supports percentage and absolute modes #42987

Merged
merged 3 commits into from
Aug 9, 2019
Merged

[Code] disk watermark supports percentage and absolute modes #42987

merged 3 commits into from
Aug 9, 2019

Conversation

mw-ding
Copy link
Contributor

@mw-ding mw-ding commented Aug 8, 2019

Summary

Support percentage and absolute mode for specifying disk watermark configs in Code to keep align with Elasticsearch here

Percentage Mode Config:

disk: {
  thresholdEnabled: true,
  watermarkLow: "90%",
}

server will complain when disk usage is above 90%.

Absolute Mode Config:

disk: {
  thresholdEnabled: true,
  watermarkLow: "100mb",
}

server will complain when available/free disk space left is below 100mb. For now, only kb, mb, gb, tb are supported.

By default, the percentage mode with 90% is used. @chongzhe we might need to update the docs.

Screenshots
Percentage mode:
image

Absolute mode:
image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/code

@mw-ding mw-ding requested a review from zfy0701 August 8, 2019 21:56
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mw-ding mw-ding merged commit 1562e62 into elastic:master Aug 9, 2019
mw-ding added a commit that referenced this pull request Aug 9, 2019
…#43054)

* [Code] disk watermark supports percentage and absolute modes

* add unit tests

* use percentage mode by default
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 12, 2019
…p-metrics-selectall

* 'master' of github.com:elastic/kibana: (22 commits)
  [Code]: downgrade the log level of error message from subprocess (elastic#42925)
  [Code] Cancel clone/update job in the middle if disk space over the watermark (elastic#42890)
  Add Kibana App specific URL to the help menu (elastic#34739) (elastic#42580)
  [Maps] refactor createShapeFilterWithMeta to support more than just polygons (elastic#43042)
  Skip flaky es_ui_shared/request tests.
  Pass uiSettings to all data plugin services (elastic#42159)
  [SIEM] Upgrades react-redux and utilize React.memo for performance gains  (elastic#43029)
  [skip-ci][Maps] add maki icon sheet to docs (elastic#43063)
  Adding "style-src 'unsafe-inline' 'self'" to default CSP rules (elastic#41305)
  Update dependency commander to v3 (elastic#43041)
  Update dependency @percy/agent to ^0.10.0 (elastic#40517)
  [Maps] only show top hits checkbox if index has date fields (elastic#43056)
  run chained_controls on Firefox to catch regression (elastic#43044)
  fixing issue with dashboard csv download (elastic#42964)
  Expose task manager as plugin instead of server argument (elastic#42966)
  Expose createRouter from HttpService, prepare handlers for context introduction (elastic#42686)
  [Code] disk watermark supports percentage and absolute modes (elastic#42987)
  [apps/dashboard] skip part of filtering tests on FF (elastic#43047)
  [ML] Kibana management jobs list (elastic#42570)
  [ML] Fix check for watcher being enabled (elastic#43025)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants