[Monitoring] Use async/await pattern which should address weird bug #42876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
Team:Monitoring
|
Pinging @elastic/stack-monitoring |
💔 Build Failed |
💚 Build Succeeded |
…e_async_in_bulk_fetch
💚 Build Succeeded |
igoristic
approved these changes
Aug 9, 2019
|
Working as expected with no errors. Great job! 💪 |
This was referenced Aug 9, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Aug 9, 2019
…lastic#42876) * Use async/await pattern which should address weird bug * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41830
Resolves #42778
I'm not exactly sure why, but the existing code caused this issue and I suspect it has something to do with how Bluebird Promise.props works. I'm not familiar with it, but we might as well as migrate this to using more up to date patterns, which seems to fix the linked bugs too.