Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] [skip ci] Remove extraneous responsibilities of courier #34508

Closed
wants to merge 21 commits into from

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Apr 3, 2019

Summary

Part of #34022.

  • Simplifies the way search strategies are looked up and assigned
  • Removes the search poller and moves the responsibility to the timefilter service
  • Removes the search request queue and moves responsibility to fetchSoon
  • Search request queue should only contain search requests, not a mix including request statuses
  • Removes most of the lifecycle from search request (it wasn't being used)
  • Simplifies handling of aborted requests
  • Simplifies SearchRequest interface & removes things that were unimplemented (like incomplete/retry/continue)
  • Removes logic surrounding querying time-based interval index patterns

Checklist

For maintainers

@lukasolson lukasolson self-assigned this Apr 3, 2019
@lukasolson lukasolson added :AppArch Feature:Search Querying infrastructure in Kibana WIP Work in progress labels Apr 3, 2019
this._searchStrategyId = undefined;
this._fields = parseInitialFields(initialFields);
this._parent = undefined;

this.history = [];
this._requestStartHandlers = [];
this._inheritOptions = {};

this._filterPredicates = [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are filtered as part of the call below in buildEsQuery

@@ -173,38 +141,6 @@ export function SearchSourceProvider(Promise, Private, config) {
throw new Error(`Can't set field '${field}' on SearchSource. Acceptable fields are: ${FIELDS.join(', ')}.`);
}

if (field === 'index') {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic was over-complicated and moved here

@lukasolson
Copy link
Member Author

Decided to close in favor of #38737.

@lukasolson lukasolson closed this Jun 12, 2019
@lukasolson lukasolson mentioned this pull request Sep 3, 2019
14 tasks
@lukasolson lukasolson deleted the rmCourierCruft branch December 2, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana v8.0.0 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant