-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] [skip ci] Remove extraneous responsibilities of courier #34508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
:AppArch
Feature:Search
Querying infrastructure in Kibana
WIP
Work in progress
labels
Apr 3, 2019
lukasolson
commented
Apr 8, 2019
this._searchStrategyId = undefined; | ||
this._fields = parseInitialFields(initialFields); | ||
this._parent = undefined; | ||
|
||
this.history = []; | ||
this._requestStartHandlers = []; | ||
this._inheritOptions = {}; | ||
|
||
this._filterPredicates = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are filtered as part of the call below in buildEsQuery
lukasolson
commented
Apr 8, 2019
@@ -173,38 +141,6 @@ export function SearchSourceProvider(Promise, Private, config) { | |||
throw new Error(`Can't set field '${field}' on SearchSource. Acceptable fields are: ${FIELDS.join(', ')}.`); | |||
} | |||
|
|||
if (field === 'index') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic was over-complicated and moved here
Decided to close in favor of #38737. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #34022.
Checklist
For maintainers